Fix Metal toolchains in Xcode 26 betas #3213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adincebic
force-pushed
the
adin/fix-metal-toolchains
branch
2 times, most recently
from
7e67c4d to
03ba4c1
Compare
adincebic
force-pushed
the
adin/fix-metal-toolchains
branch
from
ec3303c to
a1343c7
Compare
brentleyjones
approved these changes
Jul 25, 2025
brentleyjones
approved these changes
Jul 25, 2025
Contributor
|
Please squash and sign off on the git commit to pass DCO. Then we can merge this. |
Signed-off-by: Adin Cebic <[email protected]>
adincebic
force-pushed
the
adin/fix-metal-toolchains
branch
from
fc3d8f8 to
b3c8709
Compare
Contributor
Author
@brentleyjones done. |
brentleyjones
approved these changes
Jul 25, 2025
brentleyjones
merged commit 64e9631
into
MobileNativeFoundation:main
8 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Apparently
$toolchaineither was never set for Metal toolchains in earlier Xcode versions or Xcode didn't complain when it was set inaction_env. I tested on Xcode 16 and it was never there while it definitely shows up in Xcode 26 Beta 3.I think version check may not be needed here at all. If yes, please do let me know what would be suggested way of performing the check. I tried calling
xcodebuild -versionbut that seem to randomly fail for some people so I removed it.