Skip to content

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Dec 18, 2024

Change Summary

  • Add timeouts to Kafka settings class.
  • Add class with consumer-specific configuration. This is mostly copy-paste from FastStream, default values remain unchanged.
  • Create FastStream subscriber in consumer_factory instead of import time, as now options like topic names are passed via settings.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.51%. Comparing base (06b4616) to head (a79537e).
Report is 123 commits behind head on develop.

Files with missing lines Patch % Lines
data_rentgen/consumer/settings/consumer.py 84.61% 2 Missing and 2 partials ⚠️
data_rentgen/consumer/settings/kafka.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #130      +/-   ##
===========================================
- Coverage    92.56%   92.51%   -0.05%     
===========================================
  Files          171      171              
  Lines         3750     3781      +31     
  Branches       260      262       +2     
===========================================
+ Hits          3471     3498      +27     
- Misses         219      221       +2     
- Partials        60       62       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus merged commit a6040bb into develop Dec 19, 2024
9 of 10 checks passed
@dolfinus dolfinus deleted the feature/DOP-22883 branch December 19, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants