-
Notifications
You must be signed in to change notification settings - Fork 0
[DOP-22532] Adding filters for Jobs #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c504d8 to
39bdd6e
Compare
dolfinus
reviewed
Sep 24, 2025
dolfinus
reviewed
Sep 24, 2025
dolfinus
reviewed
Sep 24, 2025
dolfinus
reviewed
Sep 24, 2025
Member
|
What do you think about making |
a74592e to
46edc8b
Compare
dolfinus
reviewed
Sep 25, 2025
dolfinus
reviewed
Sep 25, 2025
dolfinus
approved these changes
Sep 25, 2025
dolfinus
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add new filters for
/v1/jobsendpoint.location_id: intid to filter by specific locationjob_type: list[str]filter by job's typeAdd new endpoint GET
/v1/jobs/job_type- to get distinct jobs from DR database.I didn't add any schema validation for location_id or job_type cause as I'm think we should return empty list if value is wrong. But maybe we should add special exceptions.
Related issue number
[DOP-22532]
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)