Skip to content

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Oct 7, 2025

Change Summary

Having multi value filters by location_type but exactly one value for location_id seems not consistent. Same for other filters by id field, like job_id, run_id, and so on.

This is not used in UI, but can be used for automatization to reduce number of requests to API.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Oct 7, 2025
@dolfinus dolfinus marked this pull request as ready for review October 7, 2025 16:14
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Coverage

Coverage Report •
FileStmtsMissCoverMissing
data_rentgen/db/repositories
   job.py72395%166, 190–191
   operation.py611181%132–133, 159–160, 163–164, 166–167, 169, 171, 179
   run.py1112973%225–226, 228–229, 231, 233, 241, 244–245, 247–248, 255–256, 259–262, 265–266, 269, 284–286, 294, 311–313, 315–316
data_rentgen/server/services
   dataset.py28196%37
   job.py21195%26
   operation.py41197%56
   run.py51198%71
TOTAL704739794% 

@dolfinus dolfinus merged commit 4aa4ee8 into develop Oct 8, 2025
11 checks passed
@dolfinus dolfinus deleted the feature/DOP-22530 branch October 8, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants