Skip to content

Commit ba14ed4

Browse files
committed
Fix S3 and IcebergRestS3 tests
1 parent c345fbe commit ba14ed4

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

tests/test_unit/test_connections/test_file_connection/test_create_s3_connection.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ async def test_developer_plus_can_create_s3_connection(
7474
"region": connection.data["region"],
7575
"protocol": connection.data["protocol"],
7676
"bucket_style": connection.data["bucket_style"],
77+
"additional_params": connection.data["additional_params"],
7778
},
7879
"auth_data": {
7980
"type": decrypted["type"],

tests/test_unit/test_connections/test_file_connection/test_read_s3_connection.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ async def test_guest_plus_can_read_s3_connection(
5858
"region": group_connection.data["region"],
5959
"protocol": group_connection.data["protocol"],
6060
"bucket_style": group_connection.data["bucket_style"],
61+
"additional_params": group_connection.data["additional_params"],
6162
},
6263
"auth_data": {
6364
"type": group_connection.credentials.value["type"],

tests/test_unit/test_connections/test_file_connection/test_update_s3_connection.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ async def test_developer_plus_can_update_s3_connection(
3636
):
3737
user = group_connection.owner_group.get_member_of_role(role_developer_plus)
3838
connection_json = await fetch_connection_json(client, user.token, group_connection)
39+
old_connection_data = connection_json["connection_data"]
3940
new_connection_data = {
4041
"bucket": "new_bucket",
4142
"host": "new_host",
@@ -58,7 +59,15 @@ async def test_developer_plus_can_update_s3_connection(
5859
"description": group_connection.description,
5960
"group_id": group_connection.group_id,
6061
"type": group_connection.type,
61-
"connection_data": new_connection_data,
62+
"connection_data": {
63+
"host": new_connection_data["host"],
64+
"bucket": new_connection_data["bucket"],
65+
"port": new_connection_data["port"],
66+
"region": new_connection_data["region"],
67+
"protocol": new_connection_data["protocol"],
68+
"bucket_style": new_connection_data["bucket_style"],
69+
"additional_params": old_connection_data["additional_params"],
70+
},
6271
"auth_data": {
6372
"type": group_connection.credentials.value["type"],
6473
"access_key": group_connection.credentials.value["access_key"],

0 commit comments

Comments
 (0)