Skip to content

Commit c345fbe

Browse files
committed
Fix S3 and IcebergRestS3 tests
1 parent 0cea771 commit c345fbe

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

syncmaster/schemas/v1/connections/s3.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class CreateS3ConnectionDataSchema(BaseModel):
2222
port: int | None = None
2323
region: str | None = None
2424
protocol: Literal["http", "https"] = "https"
25-
bucket_style: Literal["domain", "path"] = "domain"
25+
bucket_style: Literal["domain", "path"] = "path"
2626
additional_params: dict = Field(default_factory=dict)
2727

2828
@model_validator(mode="before")
@@ -43,7 +43,7 @@ class ReadS3ConnectionDataSchema(BaseModel):
4343
port: int | None = None
4444
region: str | None = None
4545
protocol: Literal["http", "https"] = "https"
46-
bucket_style: Literal["domain", "path"] = "domain"
46+
bucket_style: Literal["domain", "path"] = "path"
4747
additional_params: dict = Field(default_factory=dict)
4848

4949

tests/test_integration/test_run_transfer/connection_fixtures/iceberg_fixtures.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ def iceberg_rest_s3_for_conftest(test_settings: TestSettings) -> IcebergRESTCata
3535
s3_secret_key=test_settings.TEST_S3_SECRET_KEY,
3636
metastore_username=test_settings.TEST_ICEBERG_METASTORE_USERNAME,
3737
metastore_password=test_settings.TEST_ICEBERG_METASTORE_PASSWORD,
38+
additional_params={},
3839
)
3940

4041

@@ -56,6 +57,7 @@ def iceberg_rest_s3_for_worker(test_settings: TestSettings) -> IcebergRESTCatalo
5657
s3_secret_key=test_settings.TEST_S3_SECRET_KEY,
5758
metastore_username=test_settings.TEST_ICEBERG_METASTORE_USERNAME,
5859
metastore_password=test_settings.TEST_ICEBERG_METASTORE_PASSWORD,
60+
additional_params={},
5961
)
6062

6163

0 commit comments

Comments
 (0)