Skip to content

fix: loader should assume v1.0 if version field is missing #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
testower merged 2 commits into from
Oct 29, 2025
Merged

fix: loader should assume v1.0 if version field is missing #182

testower merged 2 commits into from
Oct 29, 2025

Conversation

@testower
Copy link
Collaborator

@testower testower commented Oct 28, 2025 •
edited
Loading

This PR does the following:

  • Similar to core validator, assume v1.0 in loader if version field is missing. The loader must determine the version in order to know how to parse the discovery file, so that it can fetch the remaining files.
  • If for some reason it's not possible to parse the information from discovery file, we will nevertheless return it so it can be properly validated.

closes #179

@testower
fix: loader should assume v1.0 if version field is missing
741d42c 
additionally, if the feeds can't be parsed from gbfs.json, return only gbfs.json file for validation

closes MobilityData#179
@CLAassistant
Copy link

CLAassistant commented Oct 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@testower testower marked this pull request as ready for review October 28, 2025 21:25
Alessandro100
Alessandro100 approved these changes Oct 29, 2025
View reviewed changes
Copy link

@Alessandro100 Alessandro100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and version 1.0 feeds are working ✅

davidgamez
davidgamez approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@testower testower merged commit d231a66 into MobilityData:master Oct 29, 2025
2 checks passed
@testower testower deleted the fix/validate-v1.0-feeds branch October 29, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamez davidgamez davidgamez approved these changes

@Alessandro100 Alessandro100 Alessandro100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validate endpoint, GBFS version 1.0 feeds return status 500

4 participants

@testower @CLAassistant @davidgamez @Alessandro100