Skip to content

feat: 1930 unknown geojson element#1973

Merged
qcdyx merged 17 commits intomasterfrom
1930
Feb 17, 2025
Merged

feat: 1930 unknown geojson element#1973
qcdyx merged 17 commits intomasterfrom
1930

Conversation

@qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Feb 6, 2025

Summary:

Closes #1930

Expected behavior:
unknown element at FeatureCollection level:
image
unknown element at feature level:
image
unknown element at geometry level:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit c3c3a0b
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1809 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1809 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1809 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1809 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1809 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.65 3.72 ⬆️+0.07
Median -- 1.32 1.38 ⬆️+0.06
Standard Deviation -- 10.42 10.40 ⬇️-0.01
Minimum in References Reports tr-kocaeli-metro-izmir-gtfs-1824 0.47 0.51 ⬆️+0.04
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 283.23 280.03 ⬇️-3.19
Minimum in Latest Reports ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 0.52 0.51 ⬇️-0.01
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 283.23 280.03 ⬇️-3.19
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 467.20 MiB 467.29 MiB ⬆️+85.91 KiB
Median -- 331.92 MiB 335.92 MiB ⬆️+4.00 MiB
Standard Deviation -- 767.04 MiB 769.47 MiB ⬆️+2.43 MiB
Minimum in References Reports mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 36.48 MiB 415.92 MiB ⬆️+379.44 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.85 GiB 10.62 GiB ⬇️-235.95 MiB
Minimum in Latest Reports ro-vrancea-consiliul-judetean-vrancea-gtfs-1984 69.31 MiB 38.28 MiB ⬇️-31.02 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.85 GiB 10.62 GiB ⬇️-235.95 MiB

@tzujenchanmbd
Copy link

Notice name, description, and displayed columns lgtm.

@github-actions
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit ae9366d
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1811 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1811 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1811 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1811 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1811 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.77 3.90 ⬆️+0.13
Median -- 1.33 1.43 ⬆️+0.10
Standard Deviation -- 11.10 10.99 ⬇️-0.11
Minimum in References Reports us-massachusetts-massachusetts-area-express-max-gtfs-431 0.47 0.74 ⬆️+0.27
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 292.85 281.69 ⬇️-11.15
Minimum in Latest Reports us-oregon-high-desert-point-gtfs-636 0.50 0.54 ⬆️+0.04
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 292.85 281.69 ⬇️-11.15
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 469.38 MiB 473.01 MiB ⬆️+3.64 MiB
Median -- 335.92 MiB 333.92 MiB ⬇️-2.00 MiB
Standard Deviation -- 778.19 MiB 808.05 MiB ⬆️+29.86 MiB
Minimum in References Reports us-california-laguna-beach-transit-lbt-gtfs-16 39.98 MiB 46.40 MiB ⬆️+6.43 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.65 GiB 11.05 GiB ⬆️+405.92 MiB
Minimum in Latest Reports us-virginia-star-transit-gtfs-819 41.89 MiB 39.96 MiB ⬇️-1.94 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.65 GiB 11.05 GiB ⬆️+405.92 MiB

Copy link
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qcdyx qcdyx merged commit 2b3e0e5 into master Feb 17, 2025
134 checks passed
@qcdyx qcdyx deleted the 1930 branch February 17, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flex: unknown_geo_json_element

4 participants