feat: duplicate key notice dynamic fieldName and fieldValue #1994
Conversation
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 46ce307 📊 Notices ComparisonNew Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
skalexch
left a comment
skalexch
left a comment
There was a problem hiding this comment.
Good on the spec side. Thanks for working on this!
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit c99e359 📊 Notices ComparisonNew Errors (1 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 164a860 📊 Notices ComparisonNew Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Summary:
Closes #1975
duplicate_keynotice to include only defined field names and values for composite keys.oldCsvRowNumberandnewCsvRowNummberExpected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything