feat: separate out missing_prior_day_booking_field_value
#1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 2c6dce9 📊 Notices ComparisonNew Errors (5 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (6 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
davidgamez
approved these changes
Mar 3, 2025
Member
davidgamez
left a comment
davidgamez
left a comment
There was a problem hiding this comment.
I love to see the replacement notice feature being expanded! I add a minor ask before approval.
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MissingPriorNoticeLastTimeNotice.java
Outdated
Show resolved
Hide resolved
...org/mobilitydata/gtfsvalidator/notice/deprecated/MissingPriorDayBookingFieldValueNotice.java
Outdated
Show resolved
Hide resolved
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit c56a269 📊 Notices ComparisonNew Errors (5 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (5 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit b243d34 📊 Notices ComparisonNew Errors (5 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (5 out of 1824 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
New Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1824 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1824 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Sergiodero
approved these changes
Mar 3, 2025
Sergiodero
left a comment
Sergiodero
left a comment
There was a problem hiding this comment.
I would suggest to change the notice description to the following (for additional clarity):
prior_notice_last_dayis required whenbooking_type=2(prior day booking) is specified in booking_rules.txt.
Other than that LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1977
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything