Skip to content

Conversation

@davidgamez
Copy link
Member

@davidgamez davidgamez commented Mar 4, 2025

Summary:

This pull request includes changes to the GitHub workflows to support the packaging and publishing of both CLI and GUI JAR assets.

Closes #1999

Expected behavior:

The GTFS-Validator GUI can be downloaded and executed from the project assets as a single JAR.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez davidgamez changed the title add gui jar generation feat: add GUI shadow jar asset Mar 4, 2025
@davidgamez davidgamez changed the title feat: add GUI shadow jar asset feat: publish the Java GUI as a independent jar asset Mar 4, 2025
@davidgamez davidgamez marked this pull request as ready for review March 4, 2025 16:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit cd0c12b
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1824 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.76 3.80 ⬆️+0.04
Median -- 1.39 1.44 ⬆️+0.04
Standard Deviation -- 10.97 10.93 ⬇️-0.04
Minimum in References Reports us-california-city-of-wasco-gtfs-1788 0.47 0.50 ⬆️+0.03
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 284.59 284.71 ⬆️+0.12
Minimum in Latest Reports us-florida-citrus-county-transit-gtfs-630 0.52 0.48 ⬇️-0.04
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 284.59 284.71 ⬆️+0.12
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 467.77 MiB 462.91 MiB ⬇️-4.86 MiB
Median -- 335.92 MiB 335.92 MiB ⬇️0 bytes
Standard Deviation -- 780.12 MiB 762.99 MiB ⬇️-17.13 MiB
Minimum in References Reports us-colorado-boulder-county-gtfs-2191 38.79 MiB 395.92 MiB ⬆️+357.13 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 11.03 GiB 10.65 GiB ⬇️-385.37 MiB
Minimum in Latest Reports us-south-dakota-sioux-area-metro-sam-gtfs-192 415.92 MiB 38.48 MiB ⬇️-377.44 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 11.03 GiB 10.65 GiB ⬇️-385.37 MiB

Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit f342c3c
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1824 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1824 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.73 3.80 ⬆️+0.07
Median -- 1.36 1.41 ⬆️+0.05
Standard Deviation -- 10.83 10.79 ⬇️-0.04
Minimum in References Reports us-california-flex-v2-developer-test-feed-3-gtfs-1819 0.45 0.55 ⬆️+0.10
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 282.29 278.94 ⬇️-3.35
Minimum in Latest Reports us-indiana-south-shore-line-gtfs-585 0.53 0.47 ⬇️-0.06
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 282.29 278.94 ⬇️-3.35
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 472.06 MiB 467.80 MiB ⬇️-4.26 MiB
Median -- 335.92 MiB 335.92 MiB ⬇️0 bytes
Standard Deviation -- 789.10 MiB 783.56 MiB ⬇️-5.54 MiB
Minimum in References Reports us-south-dakota-sioux-area-metro-sam-gtfs-192 38.51 MiB 48.27 MiB ⬆️+9.76 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.62 GiB 10.68 GiB ⬆️+55.32 MiB
Minimum in Latest Reports ro-vrancea-consiliul-judetean-vrancea-gtfs-1984 68.80 MiB 37.96 MiB ⬇️-30.84 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.62 GiB 10.68 GiB ⬆️+55.32 MiB

@davidgamez davidgamez merged commit 9f0c75a into master Mar 4, 2025
134 checks passed
@davidgamez davidgamez deleted the feat/gui-jar branch March 4, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish the Java GUI as a independent jar

3 participants