fix: web validator logging #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgamez
changed the title
Contributor
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 001ef6f 📊 Notices ComparisonNew Errors (0 out of 1866 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1866 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1866 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1866 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check55 out of 1921 sources (~3 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 001ef6f 📊 Notices ComparisonNew Errors (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check35 out of 1921 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 07bae2a 📊 Notices ComparisonNew Errors (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check35 out of 1921 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
jcpitre
reviewed
May 7, 2025
...rc/main/java/org/mobilitydata/gtfsvalidator/web/service/controller/ValidationController.java
Show resolved
Hide resolved
jcpitre
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1507
The main changes in this PR are:
Minor changes:
From our AI friend
This pull request includes changes to improve logging, enhance error handling, and configure the application for better observability and maintainability. The key updates involve refining logging levels, adding structured logging with MDC, introducing safe file deletion methods, and updating configuration files for logging and application profiles.
Logging Improvements:
INFOtoFINESTinMemoryUsageRegisterandVersionResolverto reduce verbosity for less critical messages. [1] [2]StorageHelperandValidationHandlerto useDEBUGlevel instead ofINFOfor non-critical logs, and added structured logging for better traceability. [1] [2] [3] [4]logback-spring.xmlby settingWARNlevels for specific packages and renamed the file for Spring compatibility. [1] [2]Structured Logging with MDC:
MDC(Mapped Diagnostic Context) toValidationControllerto includejob_idin logs for better traceability of validation jobs. [1] [2] [3] [4]Error Handling and Resource Management:
safeDeleteFilemethod inValidationControllerto handle file deletion safely and log any errors encountered during the process.Configuration Enhancements:
LoggingBridgeConfigclass to bridge Java Util Logging (JUL) to SLF4J, ensuring consistent logging across the application.Dockerfileto include new environment variables for Spring profiles, banner mode, and Sentry logging configuration.Testing Updates:
RunValidatorEndpointTestto verify the existence and deletion of temporary files, ensuring robust cleanup after tests. [1] [2]Expected behavior:
Logs are JSON formatted for the cloud profile. Local profile is not affected.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything