fix: Put back the limit of 50 records per notice type in the html report. #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit f7f4755 📊 Notices ComparisonNew Errors (0 out of 1866 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1866 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1866 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1866 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check55 out of 1921 sources (~3 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Contributor
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit f7f4755 📊 Notices ComparisonNew Errors (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1886 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check35 out of 1921 sources (~2 %) are corrupted.
⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
jcpitre
deleted the
2025-html-report-display-limit-is-not-working-correctly-since-v7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #2025
Reinstated the limit of 50 notices listed per notice type in the html report.
Expected behavior:
The html report should never have more than 50 notices listed per notice type.
For the sake of expediency I did not add a test case for this.
It would be way more involved since it requires parsing the resulting HTML report file.
We can add a separate issue for that.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything