fix: hide the note if the expiration date is equal to the expected date.#2039
Open
przemekwrona wants to merge 3 commits intoMobilityData:masterfrom
Open
fix: hide the note if the expiration date is equal to the expected date.#2039przemekwrona wants to merge 3 commits intoMobilityData:masterfrom
przemekwrona wants to merge 3 commits intoMobilityData:masterfrom
Conversation
|
Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:
|
emmambd
reviewed
Jul 16, 2025
| @Test | ||
| public void feedExpiring30DaysFromNowShouldGenerateNotice() { | ||
| assertThat(validateFeedInfo(createFeedInfo(GtfsDate.fromLocalDate(TEST_NOW.plusDays(30))))) | ||
| public void feedExpiring29DaysFromNowShouldGenerateNotice() { |
Contributor
There was a problem hiding this comment.
Suggestion to modify to feedExpiringAfter30DaysFromNowShouldGenerateNotice instead to conform to the actual guidance from the spec: "If possible, the GTFS dataset should cover at least the next 30 days of service." https://gtfs.org/documentation/schedule/reference/#dataset-publishing-general-practices
Contributor
|
Thanks for working on this clarification @przemekwrona! One minor suggested change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Issue #2039
While validating a GTFS feed, I received the following message:
feedEndDate: 20250712, suggestedExpirationDate: 20250712
This message is confusing because the suggestedExpirationDate is the same as the feedEndDate, which might imply that the feed is expiring exactly when it ends — but no further action or recommendation is provided. It's unclear whether this is intended or if the feed should include more future service dates.
Expected behavior:
If the dates are the same and no issue is present, the validator should not flag this message as a warning or should clarify that the feed is valid until its last service date.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything