Skip to content

feat: 2056 adding a info notice related to unsorted stop times#2095

Merged
davidgamez merged 10 commits intomasterfrom
2056-adding-a-info-notice-related-to-unsorted-stop_times
Feb 17, 2026
Merged

feat: 2056 adding a info notice related to unsorted stop times#2095
davidgamez merged 10 commits intomasterfrom
2056-adding-a-info-notice-related-to-unsorted-stop_times

Conversation

@qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Feb 11, 2026

Summary:

Closes #2056

Expected behavior:
image

image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Feb 11, 2026 that may be closed by this pull request
@qcdyx
Copy link
Contributor Author

qcdyx commented Feb 11, 2026

Hey @skalexch and @Sergiodero, do you plan to add documentation for unsorted_stop_times notice as well? Not found in here: https://gtfs-validator.mobilitydata.org/rules.html#unsorted_stop_times-rule

@davidgamez
Copy link
Member

Hey @skalexch and @Sergiodero, do you plan to add documentation for unsorted_stop_times notice as well? Not found in here: https://gtfs-validator.mobilitydata.org/rules.html#unsorted_stop_times-rule

This documentation is based on the Validation Notice Java class annotations and is auto-generated.

@github-actions
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 57d0b91
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

16 out of 1003 sources (~2 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
mdb-1332
mdb-1808
mdb-1953
mdb-227
mdb-383
mdb-55
mdb-606
mdb-609
mdb-655
mdb-780
mdb-789
mdb-806
mdb-9
mdb-907

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.45 5.75 ⬆️+0.30
Median -- 1.60 1.90 ⬆️+0.30
Standard Deviation -- 24.51 20.54 ⬇️-3.97
Minimum in References Reports mdb-6 0.49 0.88 ⬆️+0.39
Maximum in Reference Reports mdb-2014 697.44 551.48 ⬇️-145.96
Minimum in Latest Reports mdb-299 0.52 0.49 ⬇️-0.02
Maximum in Latest Reports mdb-2014 697.44 551.48 ⬇️-145.96
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 566.18 MiB 553.60 MiB ⬇️-12.58 MiB
Median -- 326.35 MiB 327.93 MiB ⬆️+1.58 MiB
Standard Deviation -- 1022.90 MiB 956.20 MiB ⬇️-66.71 MiB
Minimum in References Reports mdb-77 39.30 MiB 415.93 MiB ⬆️+376.63 MiB
Maximum in Reference Reports mdb-2393 10.09 GiB 9.31 GiB ⬇️-804.21 MiB
Minimum in Latest Reports mdb-107 42.11 MiB 40.18 MiB ⬇️-1.94 MiB
Maximum in Latest Reports mdb-2393 10.09 GiB 9.31 GiB ⬇️-804.21 MiB

@qcdyx qcdyx requested a review from skalexch February 12, 2026 14:34
Copy link
Contributor

@skalexch skalexch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qcdyx looks correct both logic-wise and looking at the unit tests. If you want to further check, you can take a GTFS feed and scramble the stop_times in both ways.

@qcdyx
Copy link
Contributor Author

qcdyx commented Feb 12, 2026

@skalexch Thanks for approving my PR! The screenshot already includes both scenarios.
In rows 2–4, the stop sequences are 1, 3, 2, which covers the second case (non-increasing stop_sequence).
Additionally, row 10 shows a trip_id ending in 0932, followed by row 11 with a trip_id ending in 0914, which demonstrates the non-contiguous trip block case.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 224cf20
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (1 out of 987 datasets, ~0%) ✅

Details of new errors due to code change, which is less than the provided threshold of 1%.

Dataset Notice Code
mdb-2014 csv_parsing_failed
Dropped Errors (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 987 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

16 out of 1003 sources (~2 %) are corrupted.
Dataset Ref Report Exists Ref Report Readable Latest Report Exists Latest Report Readable
mdb-1114
mdb-1123
mdb-1332
mdb-1808
mdb-1953
mdb-227
mdb-383
mdb-55
mdb-606
mdb-609
mdb-655
mdb-780
mdb-789
mdb-806
mdb-9
mdb-907

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 5.59 6.01 ⬆️+0.42
Median -- 1.49 1.82 ⬆️+0.33
Standard Deviation -- 22.20 22.19 ⬇️-0.01
Minimum in References Reports mdb-518 0.44 0.53 ⬆️+0.09
Maximum in Reference Reports mdb-2014 582.83 578.01 ⬇️-4.82
Minimum in Latest Reports mdb-1788 0.49 0.49 ⬇️-0.00
Maximum in Latest Reports mdb-2014 582.83 578.01 ⬇️-4.82
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 564.92 MiB 575.23 MiB ⬆️+10.31 MiB
Median -- 327.93 MiB 327.93 MiB ⬇️0 bytes
Standard Deviation -- 1005.25 MiB 1.01 GiB ⬆️+30.52 MiB
Minimum in References Reports mdb-2297 41.37 MiB 43.24 MiB ⬆️+1.87 MiB
Maximum in Reference Reports mdb-2014 9.42 GiB 9.28 GiB ⬇️-148.52 MiB
Minimum in Latest Reports mdb-1984 41.68 MiB 39.99 MiB ⬇️-1.69 MiB
Maximum in Latest Reports mdb-2014 9.42 GiB 9.28 GiB ⬇️-148.52 MiB

@davidgamez davidgamez merged commit 4a70dc2 into master Feb 17, 2026
107 checks passed
@davidgamez davidgamez deleted the 2056-adding-a-info-notice-related-to-unsorted-stop_times branch February 17, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a INFO notice related to unsorted stop_times

3 participants