feat: warn when trip_headsign matches intermediate stop name#2139
Open
PatrickSteil wants to merge 1 commit intoMobilityData:masterfrom
Open
feat: warn when trip_headsign matches intermediate stop name#2139PatrickSteil wants to merge 1 commit intoMobilityData:masterfrom
PatrickSteil wants to merge 1 commit intoMobilityData:masterfrom
Conversation
|
Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:
|
Contributor
Author
|
In this PR patrickbr/gtfstidy#41, i posted the same example but with a screenshot of the trip's route, as well as implementing a fix by overwriting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new validation rule
TripHeadsignValidatorthat warns when a trip'strip_headsignmatches thestop_nameof an intermediate stop (i.e., any stop that is not the last stop of the trip). This can cause confusion for passengers boarding after that stop, as the headsign suggests the vehicle is heading somewhere it has already passed.The notice
TripHeadsignMatchesIntermediateStopNoticeis emitted as aWARNINGand includes:trip_idand its row number intrips.txttrip_headsignvaluestop_idandstop_sequenceof the intermediate stop matching thetrip_headsignstop_idof the actual last stop of the tripNoticeFieldsTesthas been updated to register a new notice field name introduced:tripHeadsign.Note that if a trip visits the last stop multiple times, then no warning is shown.
The following screenshot shows a real-world example of the official Swiss GTFS feed, where a trip passed through St. Gallen, and continues to Winterthur. But the
trip_headsignshowsSt. Gallen.