Skip to content

Conversation

@ianktc
Copy link
Contributor

@ianktc ianktc commented Nov 26, 2025

Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments, largely related to reviewing the officialness of the data

}
},
"urls": {
"direct_download": "https://www.motionbuscard.org.cy/opendata/downloadfile?file=GTFS%5C11_google_transit.zip&rel=True",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch that this is official data! https://www.motionbuscard.org.cy Let's update all the other motionbuscard URLs to be official as well as part of this PR.

"mdb_source_id": 2904,
"data_type": "gtfs",
"provider": "Czech national bus feed JDF",
"location": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to verify the officialness of the feed? Not sure from the URL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL looks like an open source cloud sharing site. Couldn't find anything online about the feed itself (I'm going to mark it as unofficial).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave it empty, not as "false"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait so if unofficial, we should just leave the field as an empty string? I thought we should mark it:

"is_official": "False"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're confident it's false we can set it as such. In this case, it's ambiguous, so I would leave it empty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmambd Seems like the is_official field has to be populated, should I change the schema? Or maybe just keep it as false for now?

https://github.com/MobilityData/mobility-database-catalogs/actions/runs/19717267545/job/56492299115?pr=1164

image

"provider": "Hamburger Verkehrsverbund GmbH (HVV)",
"status": "active",
"location": {
"country_code": "DE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks official

"extracted_on": "2025-11-26 19:33:48.552556+00:00"
},
"subdivision_name": "Hessen",
"municipality": "Wächtersbach"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like official data, am I wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked up Cross Solution and its definitely unofficial!

"subdivision_name": "Southern Finland",
"municipality": "Uusimaa"
},
"urls": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unofficial data

"data_type": "gtfs",
"provider": "TRENITALIA S.p.A.",
"status": "inactive",
"status": "deprecated",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add redirect to 1319

"municipality": "Brașov"
},
"urls": {
"direct_download": "https://raw.githubusercontent.com/szjozsef/osm2gtfs/refs/heads/master/output/gtfs/ro-ratbv.zip",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks unofficial unless you can clarify otherwise

}
},
"urls": {
"direct_download": "https://github.com/szjozsef/osm2gtfs/raw/refs/heads/master/output/gtfs/ro-ratbv.zip",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't redirect, the new feed looks unofficial. I'd add the second one but mark it as unofficial data

@ianktc ianktc self-assigned this Nov 26, 2025
@emmambd
Copy link
Contributor

emmambd commented Nov 26, 2025

@ianktc You can remove the field and then it'll work fine

@emmambd emmambd merged commit d60a147 into main Nov 26, 2025
10 checks passed
@emmambd emmambd deleted the import/november-26-eu-feeds branch November 26, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants