-
Notifications
You must be signed in to change notification settings - Fork 69
Feed Submission November 26 #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 8db5f1d.
emmambd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments, largely related to reviewing the officialness of the data
| } | ||
| }, | ||
| "urls": { | ||
| "direct_download": "https://www.motionbuscard.org.cy/opendata/downloadfile?file=GTFS%5C11_google_transit.zip&rel=True", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch that this is official data! https://www.motionbuscard.org.cy Let's update all the other motionbuscard URLs to be official as well as part of this PR.
| "mdb_source_id": 2904, | ||
| "data_type": "gtfs", | ||
| "provider": "Czech national bus feed JDF", | ||
| "location": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to verify the officialness of the feed? Not sure from the URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL looks like an open source cloud sharing site. Couldn't find anything online about the feed itself (I'm going to mark it as unofficial).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave it empty, not as "false"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait so if unofficial, we should just leave the field as an empty string? I thought we should mark it:
"is_official": "False"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're confident it's false we can set it as such. In this case, it's ambiguous, so I would leave it empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmambd Seems like the is_official field has to be populated, should I change the schema? Or maybe just keep it as false for now?
| "provider": "Hamburger Verkehrsverbund GmbH (HVV)", | ||
| "status": "active", | ||
| "location": { | ||
| "country_code": "DE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks official
| "extracted_on": "2025-11-26 19:33:48.552556+00:00" | ||
| }, | ||
| "subdivision_name": "Hessen", | ||
| "municipality": "Wächtersbach" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like official data, am I wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked up Cross Solution and its definitely unofficial!
| "subdivision_name": "Southern Finland", | ||
| "municipality": "Uusimaa" | ||
| }, | ||
| "urls": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unofficial data
| "data_type": "gtfs", | ||
| "provider": "TRENITALIA S.p.A.", | ||
| "status": "inactive", | ||
| "status": "deprecated", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add redirect to 1319
| "municipality": "Brașov" | ||
| }, | ||
| "urls": { | ||
| "direct_download": "https://raw.githubusercontent.com/szjozsef/osm2gtfs/refs/heads/master/output/gtfs/ro-ratbv.zip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks unofficial unless you can clarify otherwise
| } | ||
| }, | ||
| "urls": { | ||
| "direct_download": "https://github.com/szjozsef/osm2gtfs/raw/refs/heads/master/output/gtfs/ro-ratbv.zip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't redirect, the new feed looks unofficial. I'd add the second one but mark it as unofficial data
|
@ianktc You can remove the field and then it'll work fine |
Addresses issues:
#1095
#1133
#1140
#891
#1060
#1019
#1007
#948
#1062