Skip to content

Conversation

@ianktc
Copy link
Contributor

@ianktc ianktc commented Dec 2, 2025

Addresses contributor request from github

@ianktc
Copy link
Contributor Author

ianktc commented Dec 2, 2025

Unfortunately the duplicate RATBV feed wasn't caught because the URLs are different despite the feeds being the same.

Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianktc I see now that this is actually the same URL - any idea why our acceptance tests didn't catch it?

@ianktc
Copy link
Contributor Author

ianktc commented Dec 2, 2025

@emmambd They're pretty much the same but not quite exactly which is why it didn't fail in the github action. Its a difference between github site itself and raw CDN site (raw.githubusercontent)

https://mobilitydatabase.org/feeds/gtfs/mdb-2903: https://raw.githubusercontent.com/szjozsef/osm2gtfs/refs/heads/master/output/gtfs/ro-ratbv.zip

https://mobilitydatabase.org/feeds/gtfs/mdb-2143: https://github.com/szjozsef/osm2gtfs/raw/refs/heads/master/output/gtfs/ro-ratbv.zip

@emmambd
Copy link
Contributor

emmambd commented Dec 2, 2025

@ianktc Got it! Can you add an issue to the mobility-feed-api repo to explore doing fuzzy matches on URLs in cases like this through Retool? That way we don't forget :)

@emmambd emmambd merged commit 7ebfa7d into main Dec 3, 2025
11 checks passed
@emmambd emmambd deleted the import/december-1-contributor-request branch December 3, 2025 10:57
@ianktc ianktc mentioned this pull request Dec 8, 2025
@ianktc ianktc self-assigned this Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants