Skip to content

Feat: Add fallback mechanism to handle ssl certification error #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlfredNwolisa merged 5 commits into from
Apr 17, 2025
Merged

Feat: Add fallback mechanism to handle ssl certification error #727

AlfredNwolisa merged 5 commits into from
Apr 17, 2025
+144 −74

Conversation

@AlfredNwolisa
Copy link
Contributor

@AlfredNwolisa AlfredNwolisa commented Feb 20, 2025 •
edited
Loading

  • Refactored the fallback mechanism in helpers.py & git action to handle feeds with ssl certification issue
  • Updated unit test

@AlfredNwolisa AlfredNwolisa changed the title Feat: Improved fallback mechanism to handle ssl certification error i… Feat: Add fallback mechanism to handle ssl certification error Feb 20, 2025
@AlfredNwolisa AlfredNwolisa linked an issue Feb 20, 2025 that may be closed by this pull request
bug: SSL certification error when validating a URL #720
Closed
@AlfredNwolisa AlfredNwolisa mentioned this pull request Feb 20, 2025
Closed
@AlfredNwolisa AlfredNwolisa marked this pull request as ready for review April 16, 2025 18:30
davidgamez
davidgamez approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlfredNwolisa AlfredNwolisa merged commit 79977d9 into main Apr 17, 2025
9 checks passed
@AlfredNwolisa AlfredNwolisa deleted the fix_ssl_error branch April 17, 2025 14:32
@emmambd emmambd mentioned this pull request Apr 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidgamez davidgamez davidgamez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: SSL certification error when validating a URL

3 participants

@AlfredNwolisa @davidgamez