Https updates from Trillium feeds #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-county-transportation-district-columbia-county-rider-gtfs-246.json
davidgamez
reviewed
Feb 20, 2025
| }, | ||
| "urls": { | ||
| "direct_download": "http://oregon-gtfs.com/gtfs_data/ctuir-or-us/ctuir-or-us.zip", | ||
| "direct_download": "https://oregon-gtfs.trilliumtransit.com/gtfs_data/ctuir-or-us/ctuir-or-us.zip", |
Member
There was a problem hiding this comment.
This might be the cause of the integration test failing, a duplicated URL, https://mobilitydatabase.org/feeds/mdb-2189
Contributor
There was a problem hiding this comment.
Apparently yes, I see something about uniqueness:
tests/test_integration.py:62: AssertionError
- generated html file: file:///home/runner/work/mobility-database-catalogs/mobility-database-catalogs/mobility-catalogs-integration-tests-report.html -
=========================== short test summary info ============================
FAILED tests/test_integration.py::test_catalogs_sources_gtfs_schedule_direct_download_urls_uniqueness
========================= 1 failed, 5 passed in 6.79s ==========================
Contributor
Author
There was a problem hiding this comment.
Good catch! Fixed by adding a redirect
Contributor
|
@emmambd So it's not just switching to
And I also see this domain, just confirming it's correct...
|
Contributor
Author
|
@fredericsimard Correct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trillium informed us that they've made the switch to HTTPS for Oregon feeds. Updated URLs directly here given there's official confirmation from the data producer these are the same feeds.