Skip to content

Commit 3e6d8fc

Browse files
committed
Add local and cloud logger
1 parent 5351fc9 commit 3e6d8fc

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

api/src/feeds/impl/feeds_api_impl.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
InternalHTTPException,
3636
gbfs_feed_not_found,
3737
)
38-
from shared.common.logging_utils import Logger
38+
from shared.common.logging_utils import Logger, new_logger
3939
from shared.database.database import Database, with_db_session
4040
from shared.database_gen.sqlacodegen_models import (
4141
Feed as FeedOrm,
@@ -64,7 +64,7 @@ class FeedsApiImpl(BaseFeedsApi):
6464

6565
def __init__(self) -> None:
6666
Logger.init_logger()
67-
self.logger = Logger("FeedsApiImpl").get_logger()
67+
self.logger = new_logger("FeedsApiImpl")
6868

6969
@with_db_session
7070
def get_feed(self, id: str, db_session: Session) -> Feed:
@@ -101,7 +101,7 @@ def get_feeds(
101101
) -> List[Feed]:
102102
"""Get some (or all) feeds from the Mobility Database."""
103103
is_email_restricted = is_user_email_restricted()
104-
self.logger.debug(f"User email is restricted: {is_email_restricted}")
104+
self.logger.info(f"User email is restricted: {is_email_restricted}")
105105
feed_filter = FeedFilter(
106106
status=status, provider__ilike=provider, producer_url__ilike=producer_url, stable_id=None
107107
)

api/src/middleware/request_context_middleware.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
import logging
21
import time
32
from starlette.types import ASGIApp, Receive, Scope, Send
43

54
from middleware.request_context import RequestContext, _request_context
65
from utils.logger import HttpRequest, API_ACCESS_LOG
7-
from shared.common.logging_utils import Logger
6+
from shared.common.logging_utils import Logger, new_logger
87

98

109
class RequestContextMiddleware:
@@ -13,8 +12,8 @@ class RequestContextMiddleware:
1312
"""
1413

1514
def __init__(self, app: ASGIApp) -> None:
16-
# self.logger = logging.getLogger(API_ACCESS_LOG)
17-
self.logger = Logger(API_ACCESS_LOG).get_logger()
15+
Logger.init_logger()
16+
self.logger = new_logger(API_ACCESS_LOG)
1817
self.app = app
1918

2019
@staticmethod

api/src/shared/common/logging_utils.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,10 @@ def init_logger():
8888
def get_logger(self):
8989
return self.logger
9090

91-
def new_logger(self):
91+
def new_logger(self, name: str):
92+
"""
93+
Create a new logger with the given name.
94+
"""
9295
logging.basicConfig(level=get_env_logging_level())
96+
return logging.getLogger(name)
97+

0 commit comments

Comments
 (0)