Enhance logging when stops missing latitude and longitude when generating routes geojson file

Author: davidgamez

functions-python/pmtiles_builder/src/gtfs.py

@@ -16,5 +16,5 @@ def stop_txt_is_lat_log_required(stop_row):
     Returns:
         bool: True if both latitude and longitude is required, False otherwise.
     """
-    location_type = get_safe_value(stop_row, "location_type", 0)
+    location_type = get_safe_value(stop_row, "location_type", "0")
     return location_type in ("0", "1", "2")

functions-python/pmtiles_builder/src/gtfs_stops_to_geojson.py

@@ -4,7 +4,9 @@
 from collections import defaultdict
 
 from csv_cache import CsvCache, ROUTES_FILE, TRIPS_FILE, STOP_TIMES_FILE, STOPS_FILE
+from gtfs import stop_txt_is_lat_log_required
 from shared.helpers.runtime_metrics import track_metrics
+from shared.helpers.transform import get_safe_float
 
 logger = logging.getLogger(__name__)
 
@@ -60,10 +62,13 @@ def convert_stops_to_geojson(csv_cache: CsvCache, output_file):
         if (
             "stop_lat" not in row
             or "stop_lon" not in row
-            or not row["stop_lat"]
-            or not row["stop_lon"]
+            or get_safe_float(row, "stop_lat") is None
+            or get_safe_float(row, "stop_lon") is None
         ):
-            logger.warning(f"Missing coordinates for stop_id {stop_id}, skipping.")
+            if stop_txt_is_lat_log_required(row):
+                logger.warning(
+                    "Missing coordinates for stop_id {%s}, skipping.", stop_id
+                )
             continue
 
         # Routes serving this stop

functions-python/pmtiles_builder/tests/test_gtfs.py

@@ -16,5 +16,5 @@ def test_not_required_cases(self):
         self.assertFalse(stop_txt_is_lat_log_required({"location_type": 4}))
 
     def test_missing_location_type(self):
-        self.assertFalse(stop_txt_is_lat_log_required({}))
-        self.assertFalse(stop_txt_is_lat_log_required({"other": "value"}))
+        self.assertTrue(stop_txt_is_lat_log_required({}))
+        self.assertTrue(stop_txt_is_lat_log_required({"other": "value"}))

functions-python/pmtiles_builder/tests/test_gtfs_stops_to_geojson.py

@@ -50,7 +50,7 @@ def test_convert_stops_to_geojson(self):
             with open(output_file) as f:
                 geojson = json.load(f)
             self.assertEqual(geojson["type"], "FeatureCollection")
-            self.assertEqual(len(geojson["features"]), 2)  # skips stop with no coords
+            self.assertEqual(2, len(geojson["features"]))  # skips stop with no coords
             props = geojson["features"][0]["properties"]
             self.assertIn("stop_id", props)
             self.assertIn("route_ids", props)