Skip to content

Conversation

@Alessandro100
Copy link
Contributor

closes: https://github.com/MobilityData/product-tasks/issues/161

Summary:

On desktop and mobile the "validators" navigation options should appear in DEV and QA, gated by a feature flag

Expected behavior:

You should be able to view the validators nav menu in the header or drawer (in mobile). When selecting it, it should bring you to the 'gbfs-validator' route

Testing tips:

Using the navigation header, the gbfs validator should bring you to the gbfs validator page

NOTE

  • This PR contains the content from the POC / demo, ignore those files in this PR, it will be re-worked in future tickets. In this PR focus on the nav and feature flag code
  • I added a disabled GTFS validator option to hint to users that this is something that will come at some point

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Desktop
Screenshot 2025-10-20 at 08 33 37

Mobile
Screenshot 2025-10-20 at 08 34 07

@Alessandro100 Alessandro100 self-assigned this Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 96 🟢 100 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 56 🟢 91 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 61 🟢 95 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 95 🟠 88 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 100 🟢 100 🟢 100 🟢 100

@github-actions
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is part of this PR, we need to update the "Run Validator Report" link in the GBFS feed summary page to the new gbfs validator address

@Alessandro100
Copy link
Contributor Author

I'm not sure if this is part of this PR, we need to update the "Run Validator Report" link in the GBFS feed summary page to the new gbfs validator address

It's not a part of this PR, we have a ticket for this: https://github.com/MobilityData/product-tasks/issues/162

@Alessandro100 Alessandro100 force-pushed the feat/161-gbfs-validator-navigation branch from 3e02d4b to b1b0722 Compare October 20, 2025 18:03
@emmambd
Copy link
Collaborator

emmambd commented Oct 21, 2025

@Alessandro100 It's so beautiful 😍 I'm excited to see us integrate all our tools into one discoverable platform!

@Alessandro100
Copy link
Contributor Author

Alessandro100 commented Oct 22, 2025

gtfs and gtfs rt validator added

Screenshot 2025-10-22 at 09 03 24 Screenshot 2025-10-22 at 09 05 39

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alessandro100 Alessandro100 merged commit d9cbeb7 into main Oct 22, 2025
4 checks passed
@Alessandro100 Alessandro100 deleted the feat/161-gbfs-validator-navigation branch October 22, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants