-
Notifications
You must be signed in to change notification settings - Fork 6
Feat: gbfs validator header navigation #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/ * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/feeds * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
|
|
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1406-trnkvtb2.web.app |
davidgamez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is part of this PR, we need to update the "Run Validator Report" link in the GBFS feed summary page to the new gbfs validator address
It's not a part of this PR, we have a ticket for this: https://github.com/MobilityData/product-tasks/issues/162 |
3e02d4b to
b1b0722
Compare
|
@Alessandro100 It's so beautiful 😍 I'm excited to see us integrate all our tools into one discoverable platform! |
davidgamez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!


closes: https://github.com/MobilityData/product-tasks/issues/161
Summary:
On desktop and mobile the "validators" navigation options should appear in DEV and QA, gated by a feature flag
Expected behavior:
You should be able to view the validators nav menu in the header or drawer (in mobile). When selecting it, it should bring you to the 'gbfs-validator' route
Testing tips:
Using the navigation header, the gbfs validator should bring you to the gbfs validator page
NOTE
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anythingDesktop

Mobile
