Skip to content

Conversation

@Alessandro100
Copy link
Contributor

Summary:

closes #1414

When the feed has bounding box undefined, it would crash the page

Expected behavior:

If the bounding box is undefined, it will not display the map and instead show an error

Testing tips:

Find a feed with bounding box undefined (eg; /feeds/gtfs/mdb-1100) and see in the console that there are no errors in regards to bounding box / bounds or lat long

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@Alessandro100 Alessandro100 self-assigned this Oct 24, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran prettier on this file, nothing changed

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 86 🟢 100 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 85 🟢 91 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 57 🟢 95 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 90 🟠 88 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1416-6os259oi.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 100 🟢 100 🟢 100 🟢 100

@github-actions
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1416-6os259oi.web.app

@Alessandro100 Alessandro100 force-pushed the fix/1414-bounding-box-undefined branch from 01f8f59 to 9601190 Compare October 24, 2025 13:21
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the quick fix 🥇

@Alessandro100 Alessandro100 merged commit d4c983e into main Oct 24, 2025
4 checks passed
@Alessandro100 Alessandro100 deleted the fix/1414-bounding-box-undefined branch October 24, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

White screen for any feed without a downloaded dataset

3 participants