Skip to content

Conversation

@Alessandro100
Copy link
Contributor

Summary:

closes #1439

Current state the pmtiles url for gtfs visualizations uses the latest dataset id to generate the url. This is not always true, instead it should use the visualization_dataset_id value from the feed endpoint instead

Expected behavior:

The pmtile url for stops and routes should be generated using the visualization_dataset_id parameter. If this value does not exist, then it will default to datasetLatest.id

Testing tips:

Go on feeds that you know have visualizations and make sure they appear

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)
Screenshot 2025-11-06 at 14 38 44 Screenshot 2025-11-06 at 14 37 17

@Alessandro100 Alessandro100 self-assigned this Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

*Lighthouse ran on https://mobility-feeds-dev--pr-1440-u9qtij79.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 85 🟢 100 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1440-u9qtij79.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 65 🟢 91 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1440-u9qtij79.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 89 🔴 0 🟢 93 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1440-u9qtij79.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 93 🟠 88 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1440-u9qtij79.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 99 🟢 100 🟢 100 🟢 100

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1440-u9qtij79.web.app

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alessandro100 Alessandro100 merged commit adc3b6c into main Nov 6, 2025
4 checks passed
@Alessandro100 Alessandro100 deleted the fix/1439-pmtiles-id branch November 6, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use visualization_dataset_id on the UI for pmtiles rendering

3 participants