fix: new pmtile url generation using visualization_dataset_id #1440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
closes #1439
Current state the pmtiles url for gtfs visualizations uses the latest dataset id to generate the url. This is not always true, instead it should use the
visualization_dataset_idvalue from the feed endpoint insteadExpected behavior:
The pmtile url for stops and routes should be generated using the
visualization_dataset_idparameter. If this value does not exist, then it will default todatasetLatest.idTesting tips:
Go on feeds that you know have visualizations and make sure they appear
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything