fix: added missing historical datasets + external ids #1512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request adds a helper function to ensure that every feed has a properly derived TransitFeeds external ID, and integrates this check into the historical dataset import process. The main goal is to improve data consistency by guaranteeing that each feed is associated with a unique external identifier from TransitFeeds.
TransitFeeds external ID management:
_ensure_transitfeeds_externalidfunction to derive and attach anExternalidwithsource='transitfeeds'to a feed, based on the TransitFeeds dataset ID. This function checks for existing IDs to avoid duplicates and logs actions for traceability._add_historical_datasetsfunction, ensuring that the external ID is set for each feed before processing historical datasets.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything