Skip to content

Conversation

@cka-y
Copy link
Contributor

@cka-y cka-y commented Nov 5, 2024

Summary:
This PR updates the GitHub workflows and functions-python codebase, focusing on adding secrets, enhancing logging, and improving code readability and maintainability.

Key Updates:

  • GitHub Workflows: Integrated 1Password secrets loading in api-deployer.yml to streamline secure credentials management.
  • Codebase Enhancements in functions-python:
    • Improved logging in feed_sync_dispatcher_transitland/src/main.py to provide clearer insight into data fetching and processing steps.
    • Refactored database queries to use SQLAlchemy ORM for more maintainable, readable queries.
    • Adjusted function configurations to extend timeouts and modify instance settings for optimized performance (in function_config.json).
    • Added configuration and deployment details in Terraform.

Closes https://github.com/MobilityData/product-tasks/issues/101

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as ready for review November 6, 2024 18:15
@cka-y cka-y requested a review from davidgamez November 11, 2024 17:37
@cka-y cka-y requested a review from AlfredNwolisa November 12, 2024 14:58
@cka-y
Copy link
Contributor Author

cka-y commented Nov 12, 2024

Adding @AlfredNwolisa as reviewer for visibility on the changes 👀

for_each = {
dataset_updates = google_pubsub_topic.dataset_updates.name
validate_gbfs_feed = google_pubsub_topic.validate_gbfs_feed.name
feed_sync_dispatcher_transitland = google_pubsub_topic.transitland_feeds_dispatch.name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cka-y cka-y merged commit 1e22f75 into main Nov 13, 2024
2 checks passed
@cka-y cka-y deleted the feat/pt-101 branch November 13, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants