Skip to content

Conversation

@cka-y
Copy link
Contributor

@cka-y cka-y commented Nov 11, 2024

Summary:
This pull request updates the Slack notification action and integrates it into various GitHub workflows to send priority-based alerts on failure. It also includes documentation updates for the workflows.

Updates to Slack Notification Action:

  • Enhanced the Slack notification action to send alerts based on priority levels with an optional step description. (.github/actions/notify-slack/action.yml)

Integration of Slack Notifications into Workflows:

  • Added notify-slack-on-failure job to multiple workflows to send Slack notifications on failure:
    • datasets-batch-deployer-dev.yml
    • db-update-dev.yml
    • db-update-prod.yml
    • db-update-qa.yml
    • release-qa.yml
    • release.yml
    • validator-update.yml

Documentation Updates:

  • Added a comprehensive table documenting all GitHub workflows, including descriptions, triggers, dependencies, and Slack notification settings. (docs/GitHubWorkflows.md)
    Summarize the changes in the pull request including how it relates to any issues (include the #number, or link them).

Expected behavior:
Screenshot 2024-11-11 at 3 26 56 PM

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y linked an issue Nov 11, 2024 that may be closed by this pull request
3 tasks
@cka-y cka-y changed the title feat: notify slack on failure feat: notify slack on gh action workflows failure Nov 11, 2024
@cka-y cka-y marked this pull request as ready for review November 11, 2024 20:29
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cka-y cka-y merged commit 276fbe6 into main Nov 12, 2024
@cka-y cka-y deleted the feat/789 branch November 12, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Slack notifications for failing actions

3 participants