-
Notifications
You must be signed in to change notification settings - Fork 6
fix: trigger downstream tasks when a new feed is added #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgamez
reviewed
Nov 12, 2024
davidgamez
approved these changes
Nov 13, 2024
Member
davidgamez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request introduces updates to enhance logging, authentication, and error handling in
api/src/scripts/load_dataset_on_create.pyand related files.load_dataset_on_create.pyfor more structured, consistent log messages.populate_db_gtfs.pyto ensure critical events are logged appropriately.load_dataset_on_create.pynow blocks until confirmation is received, preventing potential issues with unacknowledged messages.Issue Explanation:
Several issues were identified and addressed in this update:
project_idandpubsub_topic_namewere incorrectly set. These variables were initialized at a high level in the script before the environment file was fully loaded, resulting in attempts to publish to the default (dev) topic instead of the QA topic or PROD topic.Testing Instructions:
To test the updates:
stable_id>mdb-2155) should all have a corresponding dataset in QA and PROD environments.mdb-2156in QA here: QA Feed Example.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything