chore: Functions python refactoring

.github/workflows/api-deployer.yml

@@ -201,10 +201,6 @@ jobs:
           name: database_gen
           path: api/src/database_gen/
 
-      - name: Copy to db models to functions directory
-        run: |
-          cp -R api/src/database_gen/ functions-python/database_gen
-
       # api schema was generated and uploaded in api-build-test job above.
       - uses: actions/download-artifact@v4
         with:
@@ -249,10 +245,6 @@ jobs:
           name: database_gen
           path: api/src/database_gen/
 
-      - name: Copy to db models to functions directory
-        run: |
-          cp -R api/src/database_gen/ functions-python/database_gen
-
       # api schema was generated and uploaded in api-build-test job above.
       - uses: actions/download-artifact@v4
         with:

.github/workflows/build-test.yml

@@ -1,12 +1,14 @@
 name: Build and Test
 on:
-  pull_request:
-    branches: [ main ]
-    paths-ignore:
-      - '**.md'
-      - "web-app/**"
-      - "functions/**"
-      - ".github/workflows/web-*.yml"
+#  pull_request:
+#    branches: [ main ]
+#    paths-ignore:
+#      - '**.md'
+#      - "web-app/**"
+#      - "functions/**"
+#      - ".github/workflows/web-*.yml"
+  push:
+    branches: [ functions-python-refactoring ]
   workflow_call:
 
 env:

.github/workflows/datasets-batch-deployer.yml

@@ -119,7 +119,7 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: database_gen
-          path: functions-python/database_gen/
+          path: api/src/database_gen/
 
       - name: Build python functions
         run: |

functions-python/.gitignore

@@ -1 +1,3 @@
-.dist
+.dist
+shared
+test_shared

functions-python/batch_datasets/function_config.json

@@ -5,7 +5,8 @@
   "timeout": 20,
   "memory": "256Mi",
   "trigger_http": true,
-  "include_folders": ["database_gen", "helpers", "dataset_service"],
+  "include_folders": ["helpers", "dataset_service"],
+  "include_api_folders": ["database_gen"],
   "secret_environment_variables": [
     {
       "key": "FEEDS_DATABASE_URL"

functions-python/batch_datasets/main_local_debug.py

@@ -12,7 +12,7 @@
 
 # Usage:
 # - python batch_datasets/main_local_debug.py
-from src.main import batch_datasets
+from main import batch_datasets
 from dotenv import load_dotenv
 
 # Load environment variables from .env.local

functions-python/batch_datasets/tests/test_batch_datasets_main.py

@@ -18,7 +18,7 @@
 from unittest import mock
 import pytest
 from unittest.mock import Mock, patch, MagicMock
-from batch_datasets.src.main import get_non_deprecated_feeds, batch_datasets
+from main import get_non_deprecated_feeds, batch_datasets
 from test_utils.database_utils import get_testing_session, default_db_url
 
 
@@ -39,8 +39,8 @@ def test_get_non_deprecated_feeds():
         "FEEDS_LIMIT": "5",
     },
 )
-@patch("batch_datasets.src.main.publish")
-@patch("batch_datasets.src.main.get_pubsub_client")
+@patch("main.publish")
+@patch("main.get_pubsub_client")
 def test_batch_datasets(mock_client, mock_publish):
     mock_client.return_value = MagicMock()
     with get_testing_session() as session:
@@ -64,7 +64,7 @@ def test_batch_datasets(mock_client, mock_publish):
                     ]
 
 
-@patch("batch_datasets.src.main.Database")
+@patch("main.Database")
 def test_batch_datasets_exception(database_mock):
     exception_message = "Failure occurred"
     mock_session = MagicMock()

functions-python/batch_process_dataset/function_config.json

@@ -5,7 +5,8 @@
   "timeout": 540,
   "memory": "2Gi",
   "trigger_http": true,
-  "include_folders": ["database_gen", "helpers", "dataset_service"],
+  "include_folders": ["helpers", "dataset_service"],
+  "include_api_folders": ["database_gen"],
   "secret_environment_variables": [
     {
       "key": "FEEDS_DATABASE_URL"

functions-python/batch_process_dataset/tests/test_batch_process_dataset_main.py

@@ -6,7 +6,7 @@
 from hashlib import sha256
 from typing import Final
 from unittest.mock import patch, MagicMock, Mock, mock_open
-from batch_process_dataset.src.main import (
+from main import (
     DatasetProcessor,
     DatasetFile,
     process_dataset,
@@ -40,8 +40,8 @@ def create_cloud_event(mock_data):
 
 
 class TestDatasetProcessor(unittest.TestCase):
-    @patch("batch_process_dataset.src.main.DatasetProcessor.upload_file_to_storage")
-    @patch("batch_process_dataset.src.main.DatasetProcessor.download_content")
+    @patch("main.DatasetProcessor.upload_file_to_storage")
+    @patch("main.DatasetProcessor.download_content")
     def test_upload_dataset_diff_hash(
         self, mock_download_url_content, upload_file_to_storage
     ):
@@ -80,8 +80,8 @@ def test_upload_dataset_diff_hash(
         # Upload to storage is called twice, one for the latest and one for the timestamped one
         self.assertEqual(upload_file_to_storage.call_count, 2)
 
-    @patch("batch_process_dataset.src.main.DatasetProcessor.upload_file_to_storage")
-    @patch("batch_process_dataset.src.main.DatasetProcessor.download_content")
+    @patch("main.DatasetProcessor.upload_file_to_storage")
+    @patch("main.DatasetProcessor.download_content")
     def test_upload_dataset_same_hash(
         self, mock_download_url_content, upload_file_to_storage
     ):
@@ -112,8 +112,8 @@ def test_upload_dataset_same_hash(
         mock_blob.make_public.assert_not_called()
         mock_download_url_content.assert_called_once()
 
-    @patch("batch_process_dataset.src.main.DatasetProcessor.upload_file_to_storage")
-    @patch("batch_process_dataset.src.main.DatasetProcessor.download_content")
+    @patch("main.DatasetProcessor.upload_file_to_storage")
+    @patch("main.DatasetProcessor.download_content")
     def test_upload_dataset_not_zip(
         self, mock_download_url_content, upload_file_to_storage
     ):
@@ -144,8 +144,8 @@ def test_upload_dataset_not_zip(
         mock_blob.make_public.assert_not_called()
         mock_download_url_content.assert_called_once()
 
-    @patch("batch_process_dataset.src.main.DatasetProcessor.upload_file_to_storage")
-    @patch("batch_process_dataset.src.main.DatasetProcessor.download_content")
+    @patch("main.DatasetProcessor.upload_file_to_storage")
+    @patch("main.DatasetProcessor.download_content")
     def test_upload_dataset_download_exception(
         self, mock_download_url_content, upload_file_to_storage
     ):
@@ -355,9 +355,9 @@ def test_process_no_change(self):
         self.assertIsNone(result)
         processor.create_dataset.assert_not_called()
 
-    @patch("batch_process_dataset.src.main.Logger")
-    @patch("batch_process_dataset.src.main.DatasetTraceService")
-    @patch("batch_process_dataset.src.main.DatasetProcessor")
+    @patch("main.Logger")
+    @patch("main.DatasetTraceService")
+    @patch("main.DatasetProcessor")
     def test_process_dataset_normal_execution(
         self, mock_dataset_processor, mock_dataset_trace, _
     ):
@@ -391,9 +391,9 @@ def test_process_dataset_normal_execution(
         mock_dataset_processor.assert_called_once()
         mock_dataset_processor_instance.process.assert_called_once()
 
-    @patch("batch_process_dataset.src.main.Logger")
-    @patch("batch_process_dataset.src.main.DatasetTraceService")
-    @patch("batch_process_dataset.src.main.DatasetProcessor")
+    @patch("main.Logger")
+    @patch("main.DatasetTraceService")
+    @patch("main.DatasetProcessor")
     def test_process_dataset_exception_caught(
         self, mock_dataset_processor, mock_dataset_trace, _
     ):
@@ -415,8 +415,8 @@ def test_process_dataset_exception_caught(
         # Call the function
         process_dataset(cloud_event)
 
-    @patch("batch_process_dataset.src.main.Logger")
-    @patch("batch_process_dataset.src.main.DatasetTraceService")
+    @patch("main.Logger")
+    @patch("main.DatasetTraceService")
     def test_process_dataset_missing_stable_id(self, mock_dataset_trace, _):
         db_url = os.getenv("TEST_FEEDS_DATABASE_URL", default=default_db_url)
         os.environ["FEEDS_DATABASE_URL"] = db_url

functions-python/big_query_ingestion/function_config.json

@@ -5,7 +5,8 @@
   "timeout": 540,
   "memory": "8Gi",
   "trigger_http": false,
-  "include_folders": ["database_gen", "helpers"],
+  "include_folders": ["helpers"],
+  "include_api_folders": ["database_gen"],
   "environment_variables": [],
   "secret_environment_variables": [
     {

functions-python/big_query_ingestion/src/gbfs/gbfs_big_query_ingest.py

@@ -1,6 +1,6 @@
 import os
 
-from ..common.bq_data_transfer import BigQueryDataTransfer
+from common.bq_data_transfer import BigQueryDataTransfer
 
 
 class BigQueryDataTransferGBFS(BigQueryDataTransfer):

functions-python/big_query_ingestion/src/gtfs/gtfs_big_query_ingest.py

@@ -1,6 +1,6 @@
 import os
 
-from ..common.bq_data_transfer import BigQueryDataTransfer
+from common.bq_data_transfer import BigQueryDataTransfer
 
 
 class BigQueryDataTransferGTFS(BigQueryDataTransfer):

functions-python/big_query_ingestion/src/main.py

@@ -3,8 +3,8 @@
 import functions_framework
 
 from helpers.logger import Logger
-from .gbfs.gbfs_big_query_ingest import BigQueryDataTransferGBFS
-from .gtfs.gtfs_big_query_ingest import BigQueryDataTransferGTFS
+from gbfs.gbfs_big_query_ingest import BigQueryDataTransferGBFS
+from gtfs.gtfs_big_query_ingest import BigQueryDataTransferGTFS
 
 logging.basicConfig(level=logging.INFO)
 

functions-python/big_query_ingestion/tests/test_common.py

@@ -3,27 +3,27 @@
 
 from google.cloud import bigquery
 
-from big_query_ingestion.src.common.bq_data_transfer import BigQueryDataTransfer
+from common.bq_data_transfer import BigQueryDataTransfer
 
 
 class TestBigQueryDataTransfer(unittest.TestCase):
     @patch("google.cloud.storage.Client")
-    @patch("big_query_ingestion.src.common.bq_data_transfer.bigquery.Client")
+    @patch("common.bq_data_transfer.bigquery.Client")
     def setUp(self, mock_bq_client, mock_storage_client):
         self.transfer = BigQueryDataTransfer()
         self.transfer.schema_path = "fake_schema_path.json"
         self.mock_bq_client = mock_bq_client
         self.mock_storage_client = mock_storage_client
 
-    @patch("big_query_ingestion.src.common.bq_data_transfer.bigquery.DatasetReference")
+    @patch("common.bq_data_transfer.bigquery.DatasetReference")
     def test_create_bigquery_dataset_exists(self, _):
         self.mock_bq_client().get_dataset.return_value = True
         self.transfer.create_bigquery_dataset()
 
         self.mock_bq_client().get_dataset.assert_called_once()
         self.mock_bq_client().create_dataset.assert_not_called()
 
-    @patch("big_query_ingestion.src.common.bq_data_transfer.bigquery.DatasetReference")
+    @patch("common.bq_data_transfer.bigquery.DatasetReference")
     def test_create_bigquery_dataset_not_exists(self, _):
         self.mock_bq_client().get_dataset.side_effect = Exception("Dataset not found")
 
@@ -32,9 +32,9 @@ def test_create_bigquery_dataset_not_exists(self, _):
         self.mock_bq_client().get_dataset.assert_called_once()
         self.mock_bq_client().create_dataset.assert_called_once()
 
-    @patch("big_query_ingestion.src.common.bq_data_transfer.load_json_schema")
-    @patch("big_query_ingestion.src.common.bq_data_transfer.json_schema_to_bigquery")
-    @patch("big_query_ingestion.src.common.bq_data_transfer.bigquery.DatasetReference")
+    @patch("common.bq_data_transfer.load_json_schema")
+    @patch("common.bq_data_transfer.json_schema_to_bigquery")
+    @patch("common.bq_data_transfer.bigquery.DatasetReference")
     def test_create_bigquery_table_not_exists(
         self, _, mock_json_schema_to_bigquery, mock_load_json_schema
     ):
@@ -53,7 +53,7 @@ def test_create_bigquery_table_not_exists(
         mock_json_schema_to_bigquery.assert_called_once()
         self.mock_bq_client().create_table.assert_called_once()
 
-    @patch("big_query_ingestion.src.common.bq_data_transfer.bigquery.DatasetReference")
+    @patch("common.bq_data_transfer.bigquery.DatasetReference")
     def test_create_bigquery_table_exists(self, _):
         self.mock_bq_client().get_table.return_value = True
 
@@ -62,7 +62,7 @@ def test_create_bigquery_table_exists(self, _):
         self.mock_bq_client().get_table.assert_called_once()
         self.mock_bq_client().create_table.assert_not_called()
 
-    @patch("big_query_ingestion.src.common.bq_data_transfer.bigquery.DatasetReference")
+    @patch("common.bq_data_transfer.bigquery.DatasetReference")
     def test_load_data_to_bigquery(self, _):
         mock_blob = MagicMock()
         mock_blob.name = "file1.ndjson"
@@ -77,7 +77,7 @@ def test_load_data_to_bigquery(self, _):
         self.mock_bq_client().load_table_from_uri.assert_called_once()
         mock_load_job.result.assert_called_once()
 
-    @patch("big_query_ingestion.src.common.bq_data_transfer.bigquery.DatasetReference")
+    @patch("common.bq_data_transfer.bigquery.DatasetReference")
     def test_load_data_to_bigquery_error(self, _):
         mock_blob = MagicMock()
         mock_blob.name = "file1.ndjson"
@@ -95,15 +95,9 @@ def test_load_data_to_bigquery_error(self, _):
             log.output[0],
         )
 
-    @patch(
-        "big_query_ingestion.src.common.bq_data_transfer.BigQueryDataTransfer.create_bigquery_dataset"
-    )
-    @patch(
-        "big_query_ingestion.src.common.bq_data_transfer.BigQueryDataTransfer.create_bigquery_table"
-    )
-    @patch(
-        "big_query_ingestion.src.common.bq_data_transfer.BigQueryDataTransfer.load_data_to_bigquery"
-    )
+    @patch("common.bq_data_transfer.BigQueryDataTransfer.create_bigquery_dataset")
+    @patch("common.bq_data_transfer.BigQueryDataTransfer.create_bigquery_table")
+    @patch("common.bq_data_transfer.BigQueryDataTransfer.load_data_to_bigquery")
     def test_send_data_to_bigquery_success(
         self, mock_load_data, mock_create_table, mock_create_dataset
     ):
@@ -116,7 +110,7 @@ def test_send_data_to_bigquery_success(
         self.assertEqual(response, "Data successfully loaded to BigQuery")
 
     @patch(
-        "big_query_ingestion.src.common.bq_data_transfer.BigQueryDataTransfer.create_bigquery_dataset",
+        "common.bq_data_transfer.BigQueryDataTransfer.create_bigquery_dataset",
         side_effect=Exception("Dataset creation failed"),
     )
     def test_send_data_to_bigquery_failure(self, mock_create_dataset):

functions-python/big_query_ingestion/tests/test_gbfs_ingestion.py

@@ -1,7 +1,7 @@
 import unittest
 from unittest.mock import patch
 
-from big_query_ingestion.src.gbfs.gbfs_big_query_ingest import BigQueryDataTransferGBFS
+from gbfs.gbfs_big_query_ingest import BigQueryDataTransferGBFS
 
 
 class TestBigQueryDataTransferGBFS(unittest.TestCase):

functions-python/big_query_ingestion/tests/test_gtfs_ingestion.py

@@ -1,7 +1,7 @@
 import unittest
 from unittest.mock import patch
 
-from big_query_ingestion.src.gtfs.gtfs_big_query_ingest import BigQueryDataTransferGTFS
+from gtfs.gtfs_big_query_ingest import BigQueryDataTransferGTFS
 
 
 class TestBigQueryDataTransferGTFS(unittest.TestCase):

functions-python/big_query_ingestion/tests/test_main.py

@@ -1,16 +1,16 @@
 import unittest
 from unittest.mock import patch
 
-from big_query_ingestion.src.main import (
+from main import (
     ingest_data_to_big_query_gtfs,
     ingest_data_to_big_query_gbfs,
 )
 
 
 class TestMain(unittest.TestCase):
-    @patch("big_query_ingestion.src.main.BigQueryDataTransferGTFS")
+    @patch("main.BigQueryDataTransferGTFS")
     @patch("helpers.logger.Logger.init_logger")
-    @patch("big_query_ingestion.src.main.logging.info")
+    @patch("main.logging.info")
     def test_ingest_data_to_big_query_gtfs(
         self, mock_logging_info, mock_init_logger, mock_big_query_transfer_gtfs
     ):
@@ -27,9 +27,9 @@ def test_ingest_data_to_big_query_gtfs(
         mock_instance.send_data_to_bigquery.assert_called_once()
         self.assertEqual(response, ("Data successfully loaded to BigQuery", 200))
 
-    @patch("big_query_ingestion.src.main.BigQueryDataTransferGBFS")
+    @patch("main.BigQueryDataTransferGBFS")
     @patch("helpers.logger.Logger.init_logger")
-    @patch("big_query_ingestion.src.main.logging.info")
+    @patch("main.logging.info")
     def test_ingest_data_to_big_query_gbfs(
         self, mock_logging_info, mock_init_logger, mock_biq_query_transfer_gbfs
     ):