Skip to content

Feat: Official Status Tag Update #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlfredNwolisa merged 4 commits into from
Jan 10, 2025
Merged

Feat: Official Status Tag Update #869

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c08454f
Add trigger for tracking `official` field updates in `feed`
AlfredNwolisa Jan 8, 2025
a34bfd1
Merge branch 'main' into official_status_tag_update
AlfredNwolisa Jan 9, 2025
216a962
Removed trigger for logging official tag changes & replaced with dire…
AlfredNwolisa Jan 10, 2025
2dc2e12
Merge remote-tracking branch 'origin/official_status_tag_update' into…
AlfredNwolisa Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions liquibase/changes/official_tag_update.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
-- Query to update official tag for feeds with contact email in the feed table where the source is mdb

UPDATE public.feed f
SET official = TRUE
FROM public.externalid e
WHERE f.id = e.feed_id
AND f.feed_contact_email LIKE '%@%'
AND e.source = 'mdb';

-- Query to insert a record in officialstatushistory table for feeds with contact email in the feed table where the source is mdb
INSERT INTO public.officialstatushistory (is_official, feed_id, reviewer_email, timestamp, notes)
SELECT
official,
id,
'[email protected]',
NOW(),
'Official status tag changed'
Copy link
Collaborator

@jcpitre jcpitre Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this note to be a bit generic.
Maybe you can ask @emmambd for a note that is specific to the operation done here.
Like: Official status set after manual verification of initial DB contents.
Or something like this.
Or maybe it's not important.

Copy link
Collaborator

@emmambd emmambd Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this alert show up? I think keeping is general is okay in case there's a world where we do automate this in the future

Copy link
Contributor Author

@AlfredNwolisa AlfredNwolisa Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmambd it shows up as a note in the officialstatushistory table for the feeds i set to official.

Copy link
Collaborator

@emmambd emmambd Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it lives in the DB I think that is sufficient.

FROM public.feed
WHERE feed_contact_email LIKE '%@%'
AND official = TRUE;
Loading