Add startDownloadNexusFileForGame#2181
Merged
Holt59 merged 1 commit intoModOrganizer2:masterfrom Jan 2, 2025
Merged
Conversation
JonathanFeenstra
force-pushed
the
nexusdownload-gamename
branch
from
cbde28c to
630adb6
Compare
JonathanFeenstra
changed the title
Holt59
reviewed
Jan 2, 2025
src/downloadmanager.h
Outdated
| @@ -405,6 +405,7 @@ class DownloadManager : public QObject | |||
| public: // IDownloadManager interface: | |||
| int startDownloadURLs(const QStringList& urls); | |||
| int startDownloadNexusFile(int modID, int fileID); | |||
Member
There was a problem hiding this comment.
If this function is not used in the main code, this should be removed an the proxy should directly call startDownloadNexusFileForGame from startDownloadNexusFile (cannot check right now if that's the case or not).
JonathanFeenstra
force-pushed
the
nexusdownload-gamename
branch
from
630adb6 to
52458b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ModOrganizer2/modorganizer-uibase#164