Stop Using Internal APIs #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModProg
approved these changes
May 14, 2025
| let _: __AssertEq<std::marker::PhantomData<T> >; | ||
| impl<T> DeriveWhereAssertEq for Test<T> { | ||
| fn assert(&self) { | ||
| struct __AssertEq<__T: ::core::cmp::Eq + ?::core::marker::Sized>(::core::marker::PhantomData<__T>); |
Owner
There was a problem hiding this comment.
at some point we could consider creating our own types for stuff like that, though that'd require a non procmacro crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the implementation of
Eqto not useEq::assert_receiver_is_total_eq()and the implementation ofZeroizeOnDropto not usezeroize::__internal. Both aredoc(hidden)and therefor unstable APIs.Resolves #115.