update model for python3 and modeldb-ci support #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no downside to declaring RANGE t0 in the mod file. |
ramcdougal
reviewed
Jul 19, 2022
| h.cvode.event(newCurrTime.value + nextInvl, self.callback) | ||
| if verbose: | ||
| print('[callback.h.t End(id= %i)] %.3f' %(pc.id(), h.t)) | ||
| print(('[callback.h.t End(id= %i)] %.3f' %(pc.id(), h.t))) |
There was a problem hiding this comment.
pedantic point, but this change isn't necessary; it was already in parentheses
Member
There was a problem hiding this comment.
I think it's a side effect from the 2to3 utility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actions followed (copied from this PR: neuronsimulator/nrn-modeldb-ci#41):
- 2to3 -w .
- reindent .
# TODO - PR to update model for python3 support
- sed -i 's/figure, hold, isscalar/figure, isscalar/g;s/hold(True)/#hold(True)/g' analysis.py
- sed -i 's/hashlib.md5(obj)/hashlib.md5(obj.encode("utf-8"))/g' shared.py
- sed -i 's/cell.t0 = .0/#cell.t0 = .0/g' izhi.py
- sed -i "s/(nCells/s.nMuscles)/int(nCells/s.nMuscles)/g;s/'w'/'wb'/g;s/s.hostspikevecs[c]/[s.hostspikevecs[c].x[i] for i in range(s.hostspikevecs[c].size())]/g" network.py