Merged
Conversation
…p to 3 times when connection timeout ♻️ Improvement: Warn the user trying to proceed to next config page when embedding model has not connected yet ♻️ Improvement: Warn the user trying to modify the embedding config (from non-empty state to other state) ♻️ Improvement: Warn the user trying to proceed to next config page when embedding model has not set (regardless of multi-embedding model) ♻️ Refactor: add EmbedderCheckModal.tsx to manage all warning modals in model config page 🐛 Bug fix: Next.js warning in the home page: Instance created by `useForm` is not connected to any Form element.
…forcement # Conflicts: # frontend/app/[locale]/setup/models/components/model/EmbedderCheckModal.tsx # frontend/app/[locale]/setup/models/components/modelConfig.tsx # frontend/app/[locale]/setup/page.tsx # frontend/public/locales/en/common.json # frontend/public/locales/zh/common.json
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…p to 3 times when connection timeout ♻️ Improvement: Warn the user trying to proceed to next config page when embedding model has not connected yet ♻️ Improvement: Warn the user trying to modify the embedding config (from non-empty state to other state) ♻️ Improvement: Warn the user trying to proceed to next config page when embedding model has not set (regardless of multi-embedding model) ♻️ Refactor: add EmbedderCheckModal.tsx to manage all warning modals in model config page 🐛 Bug fix: Next.js warning in the home page: Instance created by `useForm` is not connected to any Form element.
WMC001
reviewed
Sep 19, 2025
| user_id, tenant_id, config_key, model_id) | ||
| return | ||
|
|
||
| current_model_id = _parse_optional_int(tenant_config_dict.get(config_key)) |
Contributor
There was a problem hiding this comment.
如果需要判断是否可以转化为int可以直接使用isdigit()
_parse_optional_int方法可以改为一个简单的if语句，因为这个方法不复用，不用单独抽取
current_model_id = tenant_config_dict.get(config_key)
current_model_id = int(current_model_id) if str(current_model_id).isdigit() else None
Contributor
Author
There was a problem hiding this comment.
将在PART 2合入中统一修改
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Improvement: Now embedding model in sdk will automatically retry up to 3 times when connection timeout
♻️ Improvement: Warn the user trying to proceed to next config page when embedding model has not connected yet
♻️ Improvement: Warn the user trying to modify the embedding config (from non-empty state to other state)
♻️ Improvement: Warn the user trying to proceed to next config page when embedding model has not set (regardless of multi-embedding model)
♻️ Refactor: add EmbedderCheckModal.tsx to manage all warning modals in model config page
🐛 Bug fix: Next.js warning in the home page: Instance created by
useFormis not connected to any Form element.20250918_161322.mp4