Fix minor naming bugs

[zhangbilang]

llava has been renamed to llava-hf, and llava-lht is now renamed to llava.

[gemini-code-assist]

Hello @SmudgedWings, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a quick summary of this pull request. This PR, titled "Fix minor naming bugs", primarily addresses a consistent typo found across several model initialization methods. The variable _word_size has been corrected to _world_size in multiple files. While the description mentions renaming LLaVA variants, the actual changes in the provided patches focus solely on this specific variable name correction related to distributed processing configuration.

Highlights

• Typo Fix: Corrected a typo in the variable name _word_size to _world_size in the initialization logic of several model classes (internvl2, llava, llava_hf, minicpmv, qwen2vl, videollava, vila). This variable is related to tracking the world size in distributed training/inference setups.

Changelog

Click here to see the changelog

• llmc/models/internvl2.py
  • Corrected typo _word_size to _world_size.
• llmc/models/llava.py
  • Corrected typo _word_size to _world_size.
• llmc/models/llava_hf.py
  • Corrected typo _word_size to _world_size in two locations.
• llmc/models/minicpmv.py
  • Corrected typo _word_size to _world_size.
• llmc/models/qwen2vl.py
  • Corrected typo _word_size to _world_size.
• llmc/models/videollava.py
  • Corrected typo _word_size to _world_size.
• llmc/models/vila.py
  • Corrected typo _word_size to _world_size.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A single letter wrong,
Can make the code feel long.
Fixing 'word' to 'world',
Correctness now unfurled.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR correctly fixes a recurring typo by renaming _word_size to the standard _world_size across several model initialization routines. This is a good change that improves code correctness and clarity, especially in the context of distributed processing. Well done on catching and fixing this consistently!

However, there's a point of clarification needed regarding the PR's scope. The description mentions: 'llava has been renamed to llava-hf, and llava-lht is now renamed to llava.' These renames do not appear in the provided code patches, which solely focus on the _word_size correction. Could you please clarify if these other renames are intended to be part of this PR, or if the description needs an update?

Summary of Findings

• PR Description Mismatch with Changes: The pull request description states: 'llava has been renamed to llava-hf, and llava-lht is now renamed to llava.' However, these specific file or module renames are not present in the code changes provided in this review context, which only include corrections of the _word_size variable to _world_size. This discrepancy should be clarified. If these renames are intended for this PR, they seem to be missing. If not, the PR description should be updated to accurately reflect the changes made.

Merge Readiness

The code changes for renaming _word_size to _world_size are correct and improve the codebase. These specific changes are ready.

However, before merging, it's important to address the discrepancy noted between the PR description (regarding llava renames) and the actual changes in this PR. Clarifying this will ensure the PR's scope is well-understood and complete.

I am unable to approve PRs myself. Based on this review, I recommend resolving the point of clarification regarding the PR's scope. Once the scope is clear and matches the PR's content, the included _world_size fixes are good to go.