-
Notifications
You must be signed in to change notification settings - Fork 66
Update export lightx2v #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @gushiqiao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the model export process by ensuring that lightx2v quantized models have their configuration files accurately updated upon saving. It introduces a dedicated utility for this purpose and integrates it into the existing model deployment workflow, improving the correctness and consistency of exported model metadata.
Highlights
- New Configuration Update Utility: I've introduced a new utility function,
update_lightx2v_quant_config, specifically designed to modify the configuration file oflightx2vquantized models. This function ensures that thequant_methodfield in theconfig.jsonis correctly set toadvanced_ptqafter the model is saved. - Integration into Main Workflow: The newly created
update_lightx2v_quant_configfunction has been integrated into the main model saving logic withinllmc/__main__.py. Now, whenever alightx2vquantized model is saved, its configuration file will be automatically updated to reflect the correct quantization method.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for exporting to the lightx2v format by introducing a new utility function to update the quantization configuration and integrating it into the main script. A suggestion has been made to use os.path.join for path construction to improve robustness and cross-platform compatibility.
|
|
||
| def update_lightx2v_quant_config(save_quant_path): | ||
|
|
||
| config_file = save_quant_path + '/config.json' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using os.path.join for constructing the file path. This is more robust and cross-platform compatible.1
config_file = os.path.join(save_quant_path, 'config.json')
No description provided.