Skip to content

Fix type hint in _create_paged_xfer_handles method #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WANDY666 merged 1 commit into from
Sep 24, 2025
Merged

Fix type hint in _create_paged_xfer_handles method #1067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lightllm/server/router/model_infer/mode_backend/pd_nixl/nixl_kv_transporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def _register_kv_move_buffer(self, kv_move_buffer: Tensor):
self.page_reg_desc = self.nixl_agent.register_memory(kv_move_buffer)
self.page_local_xfer_handles = self._create_paged_xfer_handles(self.page_reg_desc, self.num_pages)

def _create_paged_xfer_handles(self, reg_desc: nixlBind.nixlRegDList, page_num: int, agent_name: str = ""):
def _create_paged_xfer_handles(self, reg_desc: "nixlBind.nixlRegDList", page_num: int, agent_name: str = ""):
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve type safety and code clarity, it's good practice to add a return type hint to the function. Based on its usage (the return value is assigned to page_xfer_handles) and the type definition of NixlAgentMetadata.page_xfer_handles in pd_io_struct.py, the return type appears to be int.

Suggested change
def _create_paged_xfer_handles(self, reg_desc: "nixlBind.nixlRegDList", page_num: int, agent_name: str = ""):
def _create_paged_xfer_handles(self, reg_desc: "nixlBind.nixlRegDList", page_num: int, agent_name: str = "") -> int:

base_addr, _, device_id, _ = reg_desc[0]
pages_data = []
for page_id in range(page_num):
Expand Down