-
Notifications
You must be signed in to change notification settings - Fork 294
feat: internvl llm support qwen3moe #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @SangChengC, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for the InternVL model utilizing the Qwen3 MOE architecture within the lightllm framework. It registers the new model type and configures it by loading the relevant configurations from the model weights directory.
Highlights
- Model Support: Adds support for the InternVL model with Qwen3 MOE (Mixture of Experts) architecture.
- Model Registry: Registers
InternVLQwen3MOETpPartModelin the model registry, associating it with theinternvl_chatmodel type when the underlying LLM isqwen3_moe. - Configuration: Initializes the model configuration by loading
llm_configfrom theconfig.jsonfile within the weight directory and repairs potentially inconsistent key names.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the qwen3_moe model to the internvl_chat model family. The implementation follows the existing pattern for other models. A suggestion was made to improve file handling robustness by specifying the encoding when reading the configuration file.
| with open(os.path.join(self.weight_dir_, "config.json"), "r") as json_file: | ||
| self.config = json.load(json_file)["llm_config"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good practice to explicitly specify the file encoding when opening text files to avoid potential UnicodeDecodeError on some platforms. Please add encoding="utf-8" to the open() call to ensure consistent behavior across different environments.
with open(os.path.join(self.weight_dir_, "config.json"), "r", encoding="utf-8") as json_file:
self.config = json.load(json_file)["llm_config"]
No description provided.