Skip to content

[fix] add visual_infer_batch_size check #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiworldwzj merged 1 commit into from
Jul 23, 2025
+10 −0
Merged

[fix] add visual_infer_batch_size check #980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lightllm/server/api_start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,16 @@ def normal_or_p_d_start(args):
else:
args.visual_nccl_ports = args.visual_nccl_ports[: args.visual_dp]

if args.visual_dp <= 0:
raise ValueError("visual_dp must be a positive integer.")

# 检查visual_infer_batch_size是否合理
if args.visual_infer_batch_size // args.visual_dp < 1 or args.visual_infer_batch_size % args.visual_dp != 0:
raise ValueError(
f"visual_infer_batch_size ({args.visual_infer_batch_size}) must be "
f"a positive integer multiple of visual_dp ({args.visual_dp})"
)
Comment on lines +165 to +169
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The error message could be improved to provide more context. Consider including the expected relationship between visual_infer_batch_size and visual_dp in the message to help users understand the requirement.

        raise ValueError(
            f"visual_infer_batch_size ({args.visual_infer_batch_size}) must be a positive integer multiple of visual_dp ({args.visual_dp})."
            f" Ensure that visual_infer_batch_size is divisible by visual_dp and that the result is at least 1."
        )


if args.disable_chunked_prefill:
args.chunked_prefill_size = args.max_req_total_len
# 普通模式下
Expand Down