fix dict.get no has default key params. #983
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hiworldwzj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on refining the code style and consistency within the manager.py file. It specifically addresses the way default values are provided to the dict.get() method, transitioning from keyword arguments to positional arguments for improved readability and adherence to common Python practices.
Highlights
- Python Dictionary Usage Refinement: Corrected the usage of the
dict.get()method across multiple instances inlightllm/server/httpserver/manager.py. The explicitdefault=keyword argument has been removed, and the default value (None) is now passed as the second positional argument, aligning with more idiomatic Python style.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
|
||
| async def abort(self, group_req_id: int): | ||
| req_status: ReqStatus = self.req_id_to_out_inf.get(group_req_id, default=None) | ||
| req_status: ReqStatus = self.req_id_to_out_inf.get(group_req_id, None) |
There was a problem hiding this comment.
The default parameter in dict.get() is positional-only. Passing None as a positional argument is the correct way to specify a default value when the key is not found.
| release_req_status: List[ReqStatus] = [] | ||
| for group_req_id_ in list(self.req_id_to_out_inf.keys()): | ||
| req_status: ReqStatus = self.req_id_to_out_inf.get(group_req_id_, default=None) | ||
| req_status: ReqStatus = self.req_id_to_out_inf.get(group_req_id_, None) |
There was a problem hiding this comment.
The default parameter in dict.get() is positional-only. Passing None as a positional argument is the correct way to specify a default value when the key is not found.
| pre_time_mark = time.time() | ||
| for group_req_id_ in list(self.req_id_to_out_inf.keys()): | ||
| req_status: ReqStatus = self.req_id_to_out_inf.get(group_req_id_, default=None) | ||
| req_status: ReqStatus = self.req_id_to_out_inf.get(group_req_id_, None) |
There was a problem hiding this comment.
The default parameter in dict.get() is positional-only. Passing None as a positional argument is the correct way to specify a default value when the key is not found.
|
|
||
| for group_req_id_ in list(self.req_id_to_out_inf.keys()): | ||
| req_status = self.req_id_to_out_inf.get(group_req_id_, default=None) | ||
| req_status = self.req_id_to_out_inf.get(group_req_id_, None) |
There was a problem hiding this comment.
The default parameter in dict.get() is positional-only. Passing None as a positional argument is the correct way to specify a default value when the key is not found.
No description provided.