Skip to content

Update reportService API endpoint for marking reports as read #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuidoBR merged 2 commits into from
Apr 25, 2025
Merged

Update reportService API endpoint for marking reports as read #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9891da
Update reportService API endpoint for marking reports as read
adamrefaey Apr 25, 2025
f1d5ff2
Update ReportsService to include userId in report update key
adamrefaey Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backend/src/reports/reports.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,10 @@ export class ReportsService {

const command = new UpdateItemCommand({
TableName: this.tableName,
Key: marshall({ id }),
Key: marshall({
userId, // Partition key
id, // Sort key
}),
UpdateExpression: 'SET #status = :status, updatedAt = :updatedAt',
ConditionExpression: 'userId = :userId', // Ensure the report belongs to the user
ExpressionAttributeNames: {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/common/api/__tests__/reportService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ vi.mock('../reportService', async (importOriginal) => {
// Mock markReportAsRead to avoid the dependency on getAuthConfig
markReportAsRead: async (reportId: string) => {
try {
const response = await axios.patch(`/api/reports/${reportId}`, {
const response = await axios.patch(`/api/reports/${reportId}/status`, {
status: 'READ',
});
return response.data;
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/common/api/reportService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export const fetchAllReports = async (): Promise<MedicalReport[]> => {
export const markReportAsRead = async (reportId: string): Promise<MedicalReport> => {
try {
const response = await axios.patch(
`${API_URL}/api/reports/${reportId}`,
`${API_URL}/api/reports/${reportId}/status`,
{
status: 'READ',
},
Expand Down