Refactor AwsBedrockService medical analysis prompt and enhance PerplexityService prompts for clarity #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xityService prompts for clarity - Updated the medical analysis prompt in AwsBedrockService to streamline instructions and focus on key extraction points. - Improved the system and user prompts in PerplexityService for reviewing medical document analyses, emphasizing accuracy and clarity in the verification process.
…letion method - Added PerplexityToolFunction, PerplexityTool, and PerplexityResponseFormat interfaces to support enhanced functionality. - Introduced tools and response_format options in PerplexityRequest for improved API interactions. - Implemented createStreamingChatCompletion method for querying the Perplexity AI API with streaming responses, including optional parameters for flexibility. - Updated error handling in the new method to improve logging and error reporting.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactor prompts for medical analysis in AwsBedrockService and PerplexityService to improve clarity and enforce strict JSON output formats.
- Updated PerplexityService interfaces and added optional parameters in chat completion requests, including streaming support.
- Modified ReportsService to update reports using UpdateItemCommand and added report existence verification with updated timestamp.
- Simplified and clarified the medical analysis prompt in AwsBedrockService to enforce strict JSON formatting and concise extraction instructions.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backend/src/services/perplexity.service.ts | Added new interfaces for tool functions and updated request optional parameters, including a new streaming chat completion method. |
| backend/src/reports/reports.service.ts | Switched from PutItemCommand to UpdateItemCommand with additional report existence checks and updated timestamp support. |
| backend/src/document-processor/services/aws-bedrock.service.ts | Refactored the medical analysis prompt to a more concise format with explicit formatting rules for JSON output. |
Comments suppressed due to low confidence (2)
backend/src/services/perplexity.service.ts:17
- [nitpick] Consider renaming the 'function' property to a more descriptive name (e.g., 'toolFunction') to avoid potential confusion with reserved keywords.
export interface PerplexityTool {
backend/src/reports/reports.service.ts:389
- Consider including the 'id' attribute in the ConditionExpression to ensure that the update strictly targets the intended report, thereby enhancing data integrity.
UpdateExpression: 'SET title = :title, bookmarked = :bookmarked, category = :category, processingStatus = :processingStatus, labValues = :labValues, summary = :summary, confidence = :confidence, status = :status, updatedAt = :updatedAt',
GuidoBR
approved these changes
Apr 25, 2025
- Revised the medical analysis prompt in AwsBedrockService tests to enhance clarity and focus on lab reports. - Ensured consistency in prompt messaging across test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Does this PR introduce a breaking change?
{...}
What needs to be documented once your changes are merged?
{...}
Additional Comments
{...}