Refactor test setup: standardize scrollIntoView function formatting and add Vitest type definitions #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the test setup by standardizing the formatting of the scrollIntoView function mock and adding Vitest type definitions.
- Standardized the function formatting for Element.prototype.scrollIntoView
- Introduced Vitest type definitions to improve type safety in tests
…nd add Vitest type definitions
adamrefaey
force-pushed
the
NO-TICKET-FIX-NPM-BUILD
branch
from
928ff96 to
3d0e228
Compare
GuidoBR
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Refactor test setup: standardize scrollIntoView function formatting and add Vitest type definitions
Does this PR introduce a breaking change?
{...}
What needs to be documented once your changes are merged?
{...}
Additional Comments
{...}