Skip to content

Conversation

@adamrefaey
Copy link
Collaborator

Change

fixes for ADE-66

Does this PR introduce a breaking change?

{...}

What needs to be documented once your changes are merged?

{...}

Additional Comments

{...}

…ents' across services and components; remove unused explainMedicalText method from PerplexityService; delete obsolete README for Document Processor Service.
@adamrefaey adamrefaey requested a review from Copilot April 30, 2025 16:27
@adamrefaey adamrefaey self-assigned this Apr 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements fixes for ADE-66 by standardizing medical report comments across the codebase and removing outdated explanation functionality from the Perplexity service. Key changes include:

  • Replacing the "summary" and "diagnoses" fields with "medicalComments" across frontend and backend models and services.
  • Removing the "explainMedicalText" method and its associated tests, with tests and controllers now referencing "reviewMedicalAnalysis" instead.
  • Updating integration and documentation files to reflect these changes.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/src/pages/Reports/components/OriginalReportTab.tsx Updated display of medical comments instead of the summary field.
frontend/src/common/models/medicalReport.ts Renamed field from summary to medicalComments.
backend/src/services/perplexity.service.ts Removed the explainMedicalText method.
backend/src/services/perplexity.service.spec.ts Removed test cases for the explainMedicalText function.
backend/src/reports/reports.service.ts Updated field assignment from summary to medicalComments.
backend/src/reports/models/report.model.ts Replaced the summary field with medicalComments.
backend/src/document-processor/services/document-processor.service.ts Removed usage of simplifiedExplanation and adjusted logging.
backend/src/document-processor/controllers/document-processor.controller.ts Updated to assign medicalComments rather than summary.
backend/src/controllers/perplexity/perplexity.controller.ts Deleted the explainMedicalText endpoint to align with service changes.
backend/src/app.module.spec.ts Updated mock data to reflect new field names.
backend/PERPLEXITY_INTEGRATION.md Revised documentation to remove explain endpoint details.
Comments suppressed due to low confidence (2)

backend/src/document-processor/services/document-processor.service.spec.ts:51

  • The Perplexity service method has been renamed to 'reviewMedicalAnalysis'. Verify that this new API name is consistently reflected across all consumers and documentation.
const testPerplexityService = { reviewMedicalAnalysis: vi.fn() };

backend/src/reports/models/report.model.ts:53

  • The field has been renamed from 'summary' to 'medicalComments'. Confirm that all API documentation and client integrations reference the updated field name.
@ApiProperty({ description: 'Medical comments related to the report' })

@GuidoBR GuidoBR merged commit 6e94445 into main Apr 30, 2025
2 checks passed
@adamrefaey adamrefaey deleted the ADE-208 branch April 30, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants