feat: enhance token management by extracting expiration from ID token and improving refresh logic #155
+178
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and improving refresh logic
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the authentication service by extracting the token expiration from the ID token and improving the token refresh logic.
- Extracts the expiration time from the ID token and converts it to a local ISO string
- Refactors and improves the token refresh functions with additional error handling and forced refresh logic when necessary
Files not reviewed (1)
- frontend/src/common/utils/i18n/resources/en/common.json: Language not supported
GuidoBR
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
DirectCognitoAuthServiceclass in the authentication service to improve token handling, including expiration checks, refresh logic, and error handling. It also adds a new localization string for displaying time-related messages.Authentication Enhancements:
expires_inandexpires_at) from the ID token, ensuring accurate tracking of token validity. (frontend/src/common/services/auth/direct-cognito-auth-service.ts, frontend/src/common/services/auth/direct-cognito-auth-service.tsR290-R311)isTokenRefreshNeeded,performTokenRefresh,updateTokensWithRefreshed) for better readability and maintainability. This includes handling scenarios where tokens are expired or about to expire. (frontend/src/common/services/auth/direct-cognito-auth-service.ts, [1] [2]frontend/src/common/services/auth/direct-cognito-auth-service.ts, frontend/src/common/services/auth/direct-cognito-auth-service.tsL556-R710)Localization:
"secondsLeft": "seconds left"to the English localization file for time-related messages. (frontend/src/common/utils/i18n/resources/en/common.json, frontend/src/common/utils/i18n/resources/en/common.jsonR56)