Skip to content

[ADE-137] - Update auth error messages for clarity and improve email validation prompt #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkestering-modus merged 2 commits into from
Mar 19, 2025
Merged

[ADE-137] - Update auth error messages for clarity and improve email validation prompt #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dbba3a
[ADE-137] - Update auth error messages for clarity and improve email …
jkestering-modus Mar 18, 2025
256d6dd
Refactor SignUp styles and update IonContent scroll behavior
jkestering-modus Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/common/utils/auth-errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ import { AuthError } from '../models/auth';
*/
export const AUTH_ERROR_MESSAGES: Record<string, string> = {
// Sign In errors
'UserNotFoundException': 'The email address or password you entered is incorrect.',
'NotAuthorizedException': 'The email address or password you entered is incorrect.',
'UserNotFoundException': 'Incorrect email or password.',
'NotAuthorizedException': 'Incorrect email or password.',
'UserNotConfirmedException': 'Please check your email to verify your account.',
'PasswordResetRequiredException': 'You need to reset your password. Please check your email.',

// Sign Up errors
'UsernameExistsException': 'This email address is already associated with an account. Please sign in or reset your password.',
'UsernameExistsException': 'This email is already linked to an account. Please sign in or reset your password.',
'InvalidPasswordException': 'Password does not meet the requirements. Please use a stronger password.',
'InvalidParameterException': 'Please check your input and try again.',

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/common/utils/i18n/resources/en/auth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"numeric": "Must contain only numbers",
"exact-length": "Must be exactly {{length}} characters",
"passwords-match": "Passwords must match",
"email": "Please enter a valid email address",
"email": "Please provide a valid email address (e.g., [email protected]).",
"required": "This field is required",
"min-length": "Must be at least {{length}} characters",
"max-length": "Must be at most {{length}} characters",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/Auth/SignUp/SignUpPage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
height: 100%;
display: flex;
flex-direction: column;
justify-content: center;
padding-top: 1rem;
}

.ls-signup-page__form {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/Auth/SignUp/SignUpPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const SignUpPage = ({ testid = 'page-signup' }: SignUpPageProps): JSX.Element =>
<ProgressProvider>
<Header title={t('signup', { ns: 'auth' })} />

<IonContent fullscreen className="ion-padding">
<IonContent fullscreen className="ion-padding" scrollY={true}>
<Container className="ls-signup-page__container" fixed>
<SignUpForm className="ls-signup-page__form" />
</Container>
Expand Down
14 changes: 7 additions & 7 deletions frontend/src/pages/Auth/SignUp/components/SignUpForm.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,30 @@
padding: 1rem;

.ls-signup-form__input {
margin-bottom: 16px;
margin-bottom: 1rem;
}

.ls-signup-form__button {
margin-top: 16px;
margin-top: 1rem;
}

&__password-guidelines {
margin-top: -8px;
margin-bottom: 16px;
margin-top: -0.5rem;
margin-bottom: 1rem;
font-size: 0.85rem;

&-header {
margin-bottom: 4px;
margin-bottom: 0.25rem;
font-weight: 500;
}

&-item {
display: flex;
align-items: center;
margin-bottom: 2px;
margin-bottom: 0.125rem;

&-icon {
margin-right: 6px;
margin-right: 0.375rem;
}

&-valid {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/Auth/SignUp/components/SignUpForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const SignUpForm = ({ className, testid = 'form-signup' }: SignUpFormProps): JSX
<AuthErrorDisplay
error={error}
showDetails={true}
className="ion-margin-bottom"
className="ion-margin-bottom ion-margin-top"
testid={`${testid}-error`}
/>

Expand Down