Skip to content

Conversation

@GuidoBR
Copy link
Contributor

@GuidoBR GuidoBR commented Mar 31, 2025

Change

Add API Gateway to the infrastructure.
Configure API Gateway + ALB to serve HTTPS.
Configure resource policy for API Gateway.

Does this PR introduce a breaking change?

{...}

What needs to be documented once your changes are merged?

{...}

Additional Comments

{...}

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@wesleyfuchter wesleyfuchter requested a review from Copilot April 1, 2025 16:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds API Gateway configuration to the infrastructure to enable HTTPS for the ALB/Fargate service and improve API management. Key changes include:

  • Importing and configuring new resources for API Gateway, Cognito authorization, and a VPC Link.
  • Reworking the Fargate service integration and load balancing to support both HTTP and HTTPS.
  • Introducing a Secrets Manager resource for SSL certificate storage.
Files not reviewed (2)
  • backend/package-lock.json: Language not supported
  • backend/package.json: Language not supported
Comments suppressed due to low confidence (2)

backend/src/iac/backend-stack.ts:57

  • [nitpick] Consider adding a separator (e.g., a hyphen) between the table name and the environment to maintain consistency with naming conventions used elsewhere (e.g., ${appName}ReportsTable-${props.environment}) for clarity.
tableName: `${appName}ReportsTable${props.environment}`,

backend/src/iac/backend-stack.ts:324

  • Verify that constructing the integration URI by appending '/{proxy}' to the Network Load Balancer DNS (which defaults to port 80) correctly maps to your Fargate service's target port (3000) via the NLB listener configuration.
uri: `${serviceUrl}/{proxy}`,

@GuidoBR GuidoBR closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants