POST /api/reports #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrefaey
reviewed
Apr 10, 2025
adamrefaey
reviewed
Apr 10, 2025
adamrefaey
reviewed
Apr 10, 2025
adamrefaey
reviewed
Apr 10, 2025
adamrefaey
reviewed
Apr 10, 2025
adamrefaey
reviewed
Apr 10, 2025
adamrefaey
reviewed
Apr 10, 2025
adamrefaey
requested changes
Apr 10, 2025
Collaborator
adamrefaey
left a comment
adamrefaey
left a comment
There was a problem hiding this comment.
@GuidoBR Nice work! We just need to make a few changes
adamrefaey
reviewed
Apr 11, 2025
backend/src/iac/backend-stack.ts
Outdated
| conditions: { | ||
| // Restrict uploads to PDF and JPG files | ||
| StringLike: { | ||
| 's3:x-amz-content-type': ['application/pdf', 'image/jpeg', 'image/jpg'], |
Collaborator
There was a problem hiding this comment.
we don't need to have validation here since that means we have the validation in many places and when we want to make any kind of change like add more file types, we'll have to change multiple places.
adamrefaey
reviewed
Apr 11, 2025
backend/src/iac/backend-stack.ts
Outdated
| const uploadBucket = new s3.Bucket(this, `${appName}UploadBucket-${props.environment}`, { | ||
| bucketName: `${appName.toLowerCase()}-uploads-${props.environment}-${this.account}`, | ||
| removalPolicy: RemovalPolicy.RETAIN, | ||
| versioned: true, // Enable versioning in production |
Collaborator
There was a problem hiding this comment.
I believe we don't need to use versioning.
adamrefaey
approved these changes
Apr 11, 2025
Collaborator
adamrefaey
left a comment
adamrefaey
left a comment
There was a problem hiding this comment.
Nice work @GuidoBR !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Does this PR introduce a breaking change?
{...}
What needs to be documented once your changes are merged?
{...}
Additional Comments
{...}