Skip to content

[ADE-152] Refactor aws-bedrock.service.ts to streamline AWS client configuration #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuidoBR merged 1 commit into from
Apr 10, 2025
Merged

[ADE-152] Refactor aws-bedrock.service.ts to streamline AWS client configuration #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 9 additions & 32 deletions backend/src/document-processor/services/aws-bedrock.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,16 +147,17 @@ Document text:
const secretAccessKey = this.configService.get<string>('aws.aws.secretAccessKey');
const sessionToken = this.configService.get<string>('aws.aws.sessionToken');

if (!region || !accessKeyId || !secretAccessKey) {
throw new Error('Missing required AWS configuration');
const clientConfig: any = { region };

if (accessKeyId && secretAccessKey) {
clientConfig.credentials = {
accessKeyId,
secretAccessKey,
...(sessionToken && { sessionToken }),
};
}

const credentials = this.createCredentialsObject(accessKeyId, secretAccessKey, sessionToken);

const client = new BedrockRuntimeClient({
region,
credentials,
});
const client = new BedrockRuntimeClient(clientConfig);

this.logger.log(
`AWS client initialized with region ${region} and credentials ${accessKeyId ? '(provided)' : '(missing)'}, session token ${sessionToken ? '(provided)' : '(not provided)'}`,
Expand All @@ -165,30 +166,6 @@ Document text:
return client;
}

/**
* Create AWS credentials object with proper typing
*/
private createCredentialsObject(
accessKeyId: string,
secretAccessKey: string,
sessionToken?: string,
): {
accessKeyId: string;
secretAccessKey: string;
sessionToken?: string;
} {
const credentials = {
accessKeyId,
secretAccessKey,
};

if (sessionToken) {
return { ...credentials, sessionToken };
}

return credentials;
}

/**
* Configure the model ID from configuration with fallback
*/
Expand Down